Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libgourou] Add new port and its dep #28037

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions ports/libgourou/portfile.cmake
@@ -0,0 +1,15 @@
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO SamuelMarks/${PORT}
REF bf9d0f82db99e76ed27ff80ca9646ceb5c5f4823
SHA512 29bd105da1658eb820f95d8b4449443f8327ef20e42283517bc7bc12698dba86051450e11988826020e36231e5c8bfeb2efed9d7dbe9d10f4f08a514de709922
HEAD_REF cmake
)

vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
)
vcpkg_cmake_install()
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/cmake/License.txt")
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include"
"${CURRENT_PACKAGES_DIR}/debug/share")
19 changes: 19 additions & 0 deletions ports/libgourou/vcpkg.json
@@ -0,0 +1,19 @@
{
"name": "libgourou",
"version": "0.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream repository on GitHub doesn't have any releases or tags, so where did this version come from?
I see that you are actually using the latest commit, so if there is no release or tags available, you should use "version-date": "2022-11-28" here (date of submission of this pr).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream repository on GitHub doesn't have any releases or tags, so where did this version come from?

@Cheney-W IIUC you are looking at an unofficial fork, but upstream is there:

See the tags on the left https://indefero.soutade.fr/p/libgourou/source/tree/master/

So shouldn't this port download from real upstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been messaging the maintainer we can wait to see if he accepts my patches I guess?- He accepted some but not all so I think this might work, but happy to try again if you push it.

"description": "libgourou is a free implementation of Adobe's ADEPT protocol used to add DRM on ePub/PDF files",
"homepage": "https://indefero.soutade.fr/p/libgourou",
"license": "LGPL-3.0-or-later",
"supports": "!windows",
"dependencies": [
"curl",
"libzip",
"openssl",
"pugixml",
"updfparser",
{
"name": "vcpkg-cmake",
"host": true
}
]
}
17 changes: 17 additions & 0 deletions ports/updfparser/portfile.cmake
@@ -0,0 +1,17 @@
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO SamuelMarks/${PORT}
REF 75942e15122c199b36c1468f8ce8e5b93d83cebc
SHA512 45502c76a3960b43fe1e84bf58bf818bfa15d120a7cce5cd2d21e2ba34961498166226544ab01ab665765e6e7d095d48610e42110506856880b0de5d224c3575
HEAD_REF cmake
)

vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
OPTIONS
-DBUILD_TESTING=OFF
)
vcpkg_cmake_install()
vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/cmake/License.txt")
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include"
"${CURRENT_PACKAGES_DIR}/debug/share")
14 changes: 14 additions & 0 deletions ports/updfparser/vcpkg.json
@@ -0,0 +1,14 @@
{
"name": "updfparser",
"version-date": "2022-12-19",
"description": "updfparser is a very simple PDF parser that will load PDF objects without interpretation",
"homepage": "https://indefero.soutade.fr/p/updfparser",
"license": "LGPL-3.0-or-later",
"supports": "!windows",
"dependencies": [
{
"name": "vcpkg-cmake",
"host": true
}
]
}
8 changes: 8 additions & 0 deletions versions/baseline.json
Expand Up @@ -4108,6 +4108,10 @@
"baseline": "3.1",
"port-version": 5
},
"libgourou": {
"baseline": "0.8.0",
"port-version": 0
},
"libgpg-error": {
"baseline": "1.46",
"port-version": 0
Expand Down Expand Up @@ -8304,6 +8308,10 @@
"baseline": "2022-06-21",
"port-version": 0
},
"updfparser": {
"baseline": "2022-12-19",
"port-version": 0
},
"urdfdom": {
"baseline": "3.1.1",
"port-version": 0
Expand Down
9 changes: 9 additions & 0 deletions versions/l-/libgourou.json
@@ -0,0 +1,9 @@
{
"versions": [
{
"git-tree": "dedf60b5899738d2d19d108be5682ba4d4f1edbb",
"version": "0.8.0",
"port-version": 0
}
]
}
14 changes: 14 additions & 0 deletions versions/u-/updfparser.json
@@ -0,0 +1,14 @@
{
"versions": [
{
"git-tree": "1bad8a1f42b8a6b61c7f0865c0119abd95f78f82",
"version-date": "2022-12-19",
"port-version": 0
},
{
"git-tree": "c1ce55a66a9b2cbd947c9574ae85e543ae5df418",
"version": "0.8.0",
"port-version": 0
}
Comment on lines +7 to +12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
},
{
"git-tree": "c1ce55a66a9b2cbd947c9574ae85e543ae5df418",
"version": "0.8.0",
"port-version": 0
}
}

]
}