[libgourou] Add new port and its dep

[SamuelMarks]

Describe the pull request

New port

• What does your PR fix?

N/A

• Which triplets are supported/not supported? Have you updated the CI baseline?

Linux, macOS

• Does your PR follow the maintainer guide?

Yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

[Cheney-W]

Please use vcpkg_install_copyright instead of file(INSTALL ...) for copyright file.

Other cl failures can be found in the log here: https://dev.azure.com/vcpkg/public/_build/results?buildId=81584&view=artifacts&pathAsName=false&type=publishedArtifacts

[SamuelMarks]

@Cheney-W That should do the trick.

[Cheney-W]

The upstream repository on GitHub doesn't have any releases or tags, so where did this version come from?
I see that you are actually using the latest commit, so if there is no release or tags available, you should use "version-date": "2022-11-28" here (date of submission of this pr).

[SamuelMarks]

See the tags on the left https://indefero.soutade.fr/p/libgourou/source/tree/master/

[dg0yt]

The upstream repository on GitHub doesn't have any releases or tags, so where did this version come from?

@Cheney-W IIUC you are looking at an unofficial fork, but upstream is there:

See the tags on the left https://indefero.soutade.fr/p/libgourou/source/tree/master/

So shouldn't this port download from real upstream?

[SamuelMarks]

I've been messaging the maintainer we can wait to see if he accepts my patches I guess?- He accepted some but not all so I think this might work, but happy to try again if you push it.

[Cheney-W]

I tried to test the usage on Linux machine with following CMakelist.txt:

cmake_minimum_required(VERSION 3.10)
project(test-project)
add_executable(main main.cpp)
find_package(libgourou CONFIG REQUIRED)
target_link_libraries(main PRIVATE gourou gourou_utils gourou_include gourou_compiler_flags)

and I got below errors:

CMake Error at offscale/scripts/buildsystems/vcpkg.cmake:582 (_add_executable):
  Target "main" links to target "pugixml::static" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?
Call Stack (most recent call first):
  CMakeLists.txt:3 (add_executable)

CMake Error at offscale/scripts/buildsystems/vcpkg.cmake:582 (_add_executable):
  Target "main" links to target "pugixml::pugixml" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?
Call Stack (most recent call first):
  CMakeLists.txt:3 (add_executable)

CMake Error at offscale/scripts/buildsystems/vcpkg.cmake:582 (_add_executable):
  Target "main" links to target "libzip::zip" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?
Call Stack (most recent call first):
  CMakeLists.txt:3 (add_executable)

CMake Error at offscale/scripts/buildsystems/vcpkg.cmake:582 (_add_executable):
  Target "main" links to target "OpenSSL::SSL" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?
Call Stack (most recent call first):
  CMakeLists.txt:3 (add_executable)

CMake Error at offscale/scripts/buildsystems/vcpkg.cmake:582 (_add_executable):
  Target "main" links to target "CURL::libcurl" but the target was not found.
  Perhaps a find_package() call is missing for an IMPORTED target, or an
  ALIAS target is missing?
Call Stack (most recent call first):
  CMakeLists.txt:3 (add_executable)

For fixing above errors, I think you should add below contents into the https://github.com/SamuelMarks/libgourou/blob/cmake/cmake/Config.cmake.in file:

include(CMakeFindDependencyMacro)

find_dependency(CURL)
find_dependency(libzip)
find_dependency(OpenSSL)
find_dependency(pugixml)

[SamuelMarks]

@Cheney-W Darn, it's been open for 2 years and no activity for 3 months (whence someone had built solution on their fork): https://gitlab.kitware.com/cmake/cmake/-/issues/20511

I'll make the changes you suggested & thanks

[Cheney-W]

@SamuelMarks Could you please apply my suggestions?

[SamuelMarks]

@Cheney-W I thought I did a week ago? - Or did I miss something?

[Cheney-W]

I added some comments in vcpkg.json file before, about the "version" and "supports", could you please take a look?

[Cheney-W]

@SamuelMarks Are you still working on this PR?

[Cheney-W]

https://github.com/microsoft/vcpkg/pull/28037/files#r1034336129
https://github.com/microsoft/vcpkg/pull/28037/files#r1034336172
https://github.com/microsoft/vcpkg/pull/28037/files#r1034349135
https://github.com/microsoft/vcpkg/pull/28037/files#r1034336205
https://github.com/microsoft/vcpkg/pull/28037/files#r1034336223
https://github.com/microsoft/vcpkg/pull/28037/files#r1034349662

Could you please apply above suggestions? Thank you!

[Cheney-W]

Suggested change

	},
	{
	"git-tree": "c1ce55a66a9b2cbd947c9574ae85e543ae5df418",
	"version": "0.8.0",
	"port-version": 0
	}
	}

[Cheney-W]

@SamuelMarks Are you still working on this PR?

[SamuelMarks]

Yes, I thought maybe I'd add Windows support first then send it through

Otherwise it's basically ready at is

[Cheney-W]

OK, please apply my suggestions by the way when you add new changes.