New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libgourou] Add new port and its dep #28037
Draft
SamuelMarks
wants to merge
12
commits into
microsoft:master
Choose a base branch
from
offscale:libgourou
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+96
−0
Draft
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
886d412
[ports/{libgourou,updfparser}/{portfile.cmake,vcpkg.json}] Add gourou…
SamuelMarks 96257b3
[ports/libgourou/portfile.cmake] { [CMakeLists.txt,**/CMakeLists.txt]…
SamuelMarks 0a75545
[ports/libgourou/portfile.cmake] { [CMakeLists.txt,**/CMakeLists.txt]…
SamuelMarks e003f32
[ports/{libgourou,updfparser}/portfile.cmake] Use new copyright insta…
SamuelMarks f72f16d
[ports/{libgourou,updfparser}/portfile.cmake] Case sensitive `vcpkg_i…
SamuelMarks e5646cf
[ports/libgourou/portfile.cmake] { [utils/CMakeLists.txt] Explicitly …
SamuelMarks 97ed2e1
[ports/libgourou/{portfile.cmake,vcpkg.json}] Add curl dependency exp…
SamuelMarks c450b22
[ports/libgourou/portfile.cmake] { [cmake/Config.cmake.in] Add third …
SamuelMarks 20beaf4
Merge branch 'master' into libgourou
SamuelMarks cea0d74
[ports/{libgourou,updfparser}/vcpkg.json] Apply changes requested in …
SamuelMarks 073b920
Merge branch 'master' into libgourou
SamuelMarks 1f0765b
Merge branch 'master' into libgourou
SamuelMarks File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO SamuelMarks/${PORT} | ||
| REF fe5af58cd2d90dcdffcfac380a761cbc2c73379a | ||
| SHA512 eda7ac209ee1e9ac523a585ad95c927e73774be5c5f62ddafc6785329dffd3ee3489fc97ee334ac61cc6a0a7456893041dc146301231550dec8cb5bb7f35554d | ||
| HEAD_REF cmake | ||
| ) | ||
|
|
||
| vcpkg_cmake_configure( | ||
| SOURCE_PATH "${SOURCE_PATH}" | ||
| ) | ||
| vcpkg_cmake_install() | ||
| vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/cmake/License.txt") | ||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include" | ||
| "${CURRENT_PACKAGES_DIR}/debug/share") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "name": "libgourou", | ||
| "version": "0.8.0", | ||
| "description": "libgourou is a free implementation of Adobe's ADEPT protocol used to add DRM on ePub/PDF files", | ||
| "homepage": "https://indefero.soutade.fr/p/libgourou", | ||
| "license": "LGPL-3.0-or-later", | ||
| "supports": "!uwp & !windows", | ||
SamuelMarks marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "dependencies": [ | ||
| "libzip", | ||
| "openssl", | ||
| "pugixml", | ||
| "updfparser", | ||
| { | ||
| "name": "vcpkg-cmake", | ||
| "host": true | ||
| }, | ||
| { | ||
| "name": "vcpkg-cmake-config", | ||
| "host": true | ||
Cheney-W marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH SOURCE_PATH | ||
| REPO SamuelMarks/${PORT} | ||
| REF 75942e15122c199b36c1468f8ce8e5b93d83cebc | ||
| SHA512 45502c76a3960b43fe1e84bf58bf818bfa15d120a7cce5cd2d21e2ba34961498166226544ab01ab665765e6e7d095d48610e42110506856880b0de5d224c3575 | ||
| HEAD_REF cmake | ||
| ) | ||
|
|
||
| vcpkg_cmake_configure( | ||
| SOURCE_PATH "${SOURCE_PATH}" | ||
| OPTIONS | ||
| -DBUILD_TESTING=OFF | ||
| ) | ||
| vcpkg_cmake_install() | ||
| vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/cmake/License.txt") | ||
| file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include" | ||
| "${CURRENT_PACKAGES_DIR}/debug/share") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "name": "updfparser", | ||
| "version": "0.8.0", | ||
SamuelMarks marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "description": "updfparser is a very simple PDF parser that will load PDF objects without interpretation", | ||
| "homepage": "https://indefero.soutade.fr/p/updfparser", | ||
| "license": "LGPL-3.0-or-later", | ||
| "supports": "!uwp & !windows", | ||
SamuelMarks marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "dependencies": [ | ||
| { | ||
| "name": "vcpkg-cmake", | ||
| "host": true | ||
| }, | ||
| { | ||
| "name": "vcpkg-cmake-config", | ||
| "host": true | ||
Cheney-W marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "versions": [ | ||
| { | ||
| "git-tree": "c7cbd4a360884f607b92076173e7c403edc17593", | ||
| "version": "0.8.0", | ||
| "port-version": 0 | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "versions": [ | ||
| { | ||
| "git-tree": "c1ce55a66a9b2cbd947c9574ae85e543ae5df418", | ||
| "version": "0.8.0", | ||
| "port-version": 0 | ||
| } | ||
| ] | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upstream repository on GitHub doesn't have any releases or tags, so where did this version come from?
I see that you are actually using the latest commit, so if there is no release or tags available, you should use
"version-date": "2022-11-28"here (date of submission of this pr).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the tags on the left https://indefero.soutade.fr/p/libgourou/source/tree/master/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cheney-W IIUC you are looking at an unofficial fork, but upstream is there:
So shouldn't this port download from real upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been messaging the maintainer we can wait to see if he accepts my patches I guess?- He accepted some but not all so I think this might work, but happy to try again if you push it.