Bug Fix #2704 - isoWeekday(String) inconsistent with isoWeekday(Number) #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvdh
changed the title
| @@ -82,6 +82,19 @@ function parseWeekday(input, locale) { | |||
| return null; | |||
| } | |||
|
|
|||
| function parseIsoWeekday(input, locale) { | |||
There was a problem hiding this comment.
I think falling back to parseWeekday is a bit excessive. If its string go through localeParse. If we now have number do the modulus. Return null if any of those fail.
|
@nvdh thank you for workung on this. Looks good just address the small comment and it will be merged. |
|
Merged in 07358ff |
ichernev
added a commit
that referenced
this pull request
Jun 14, 2016
Bug Fix #2704 - isoWeekday(String) inconsistent with isoWeekday(Number)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for issue #2704 as requested by @mj1856