Fix negative 0 in certain diff cases #3232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Glad I could write all that test scaffolding for you :-) |
|
@maggiepint not only that, but the |
|
I felt so stupid when he pointed that out 😃. One of those moments where you wonder if you're in the right profession. |
|
@maggiepint heh, nobody is stupid because they didn't think of a hack. This is not a google interview ... |
|
Merged in f01ca7a |
ichernev
added a commit
that referenced
this pull request
Jun 14, 2016
Fix negative 0 in certain diff cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3227