bug-1884718: update stackwalker to v0.21.1 #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds python3-venv to the docker config for running regression tests in docker, and adds a comment to the readme about what permissions are needed on the api key to run regression tests.
This picks up the following changes, in particular
3e18614 Use framehop and wholesym rather than symbolic for the local debuginfo symbol provider.
is expected to provide some performance improvement:Regression tests:
the cache and output sizes are unchanged, and the run times mostly look similar, but
1c990f1b-ffdb-4fd9-ba27-9ae890240301
looked notably slower, so I reran it, which got me times of 22, 11, 15, 17 and 13, so the slowdown seems consistent.In addition to the crashes in the regression test report, I also tested the error crash from rust-minidump/rust-minidump#967, and both before and after the update it returned: