Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glob-parent audit issue #368

Closed
nicososadmi opened this issue Jul 18, 2022 · 11 comments
Closed

glob-parent audit issue #368

nicososadmi opened this issue Jul 18, 2022 · 11 comments
Milestone

Comments

@nicososadmi
Copy link

Environment

  • OS Version: Windows 10
  • Node.js Version: 14.17

Actual behavior

After install fast-glob npm throws audit security issues with that dependency glob-parent that version should be >= 6.0.1

Expected behavior

Install fast-glob without any npm audit security issue

Steps to reproduce

npm install fast-glob

@Kurt-von-Laven
Copy link

Kurt-von-Laven commented Jul 18, 2022

fast-glob presently pins glob-parent to v5, which isn't currently patched. This issue impacts Yarn users, which both transitively depend on fast-glob.

@nicososadmi
Copy link
Author

@Kurt-von-Laven can you approve this PR? #367

@Kurt-von-Laven
Copy link

Yes, but it won't do you any good.

@mrmlnc mrmlnc added this to the 4.0.0 milestone Jul 19, 2022
@Eusebius1920
Copy link

Eusebius1920 commented Jul 19, 2022

chokidar claims that glob-parent v5.1.2 is not vulnerable:
paulmillr/chokidar#1191

@paulmillr
Copy link

It is not vulnerable, so the bug is bogus, you need to report this issue to Github support, which errorneusly added the cve to dependabot

@paulmillr
Copy link

github/advisory-database#531

@fhljys
Copy link

fhljys commented Jul 26, 2022

following

@Kurt-von-Laven
Copy link

@fhljys FYI, you can click on "Subscribe" in the "Notifications" section in order to follow a thread if that is your intention in posting.

@melwynjensen
Copy link

@paulmillr didn't understand what does it mean the bug is bogus? according to the report -> GHSA-cj88-88mr-972w glob-parent is vulnerable before 6.0.1, can you please clarify?

@Eusebius1920
Copy link

@paulmillr didn't understand what does it mean the bug is bogus? according to the report -> GHSA-cj88-88mr-972w glob-parent is vulnerable before 6.0.1, can you please clarify?

Apparently that report was incorrect (false positive).

Take a look at it again. It got corrected and specifies that 5.1.2 is not vulnerable.

@Kurt-von-Laven
Copy link

@mrmlnc, I believe this issue can safely be closed at this point since it was simply a false positive from a security audit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants