Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update glob-parent to 6.0.1 #367

Conversation

martijnversluis
Copy link

What is the purpose of this pull request?

Solving CVE-2021-35065 (GHSA-cj88-88mr-972w)

What changes did you make? (Give an overview)

Updating glob-parent to 6.0.1

Copy link

@Kurt-von-Laven Kurt-von-Laven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kurt-von-Laven
Copy link

Fixes #368.

@sawilde
Copy link

sawilde commented Jul 19, 2022

LGTM 🚀

@mrmlnc mrmlnc added this to the 4.0.0 milestone Jul 19, 2022
@mrmlnc
Copy link
Owner

mrmlnc commented Jul 19, 2022

JFYI: #331 (comment) and below.

@paulmillr
Copy link

  1. This is useless, it does not fix anything. There is no vulnerability in glob-parent 5.1.2. GHSA-cj88-88mr-972w is wrong, see https://snyk.io/vuln/npm:glob-parent
  2. This would break your support for nodejs v8.

@paulmillr
Copy link

paulmillr commented Jul 19, 2022

The alert is false, report this to GitHub: github/advisory-database#531

@nicososadmi
Copy link

Another solution for that is using npm-force-resolutions, so you need to run npm install npm-force-resolutions, then you need to add "preinstall": "node_modules/.bin/npm-force-resolutions" into package.json scripts, and then add this below

"resolutions": {
    "glob-parent": "^6.0.1"
  },

and run npm install again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants