libmysql: fix musl compatibility #385
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The musl C library does not support res_ninit, res_nsearch and res_nclose. Check if res_ninit is defined, and use res_search if not. Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
|
OCA approved and processed. |
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
thesamesam
added a commit
to thesamesam/mysql-server
that referenced
this pull request
Nov 15, 2023
musl doesn't have res_n* functions so we are falling back to the not thread safe ones. Note that another approach was submitted at https://bugs.mysql.com/bug.php?id=106034 (mysql#385) but that is arguably less portable given it takes the new path for everything non-glibc where things may already work fine (e.g. Solaris). This patch is less invasive. Bug: https://bugs.gentoo.org/761352 See also: mysql#385 See also: https://bugs.mysql.com/bug.php?id=106034
parona-source
pushed a commit
to parona-source/mysql-server
that referenced
this pull request
Jan 26, 2024
musl doesn't have res_n* functions so we are falling back to the not thread safe ones. Note that another approach was submitted at https://bugs.mysql.com/bug.php?id=106034 (mysql#385) but that is arguably less portable given it takes the new path for everything non-glibc where things may already work fine (e.g. Solaris). This patch is less invasive. Bug: https://bugs.gentoo.org/761352 See also: mysql#385 See also: https://bugs.mysql.com/bug.php?id=106034
parona-source
pushed a commit
to parona-source/mysql-server
that referenced
this pull request
May 10, 2024
musl doesn't have res_n* functions so we are falling back to the not thread safe ones. Note that another approach was submitted at https://bugs.mysql.com/bug.php?id=106034 (mysql#385) but that is arguably less portable given it takes the new path for everything non-glibc where things may already work fine (e.g. Solaris). This patch is less invasive. Bug: https://bugs.gentoo.org/761352 See also: mysql#385 See also: https://bugs.mysql.com/bug.php?id=106034
parona-source
pushed a commit
to parona-source/mysql-server
that referenced
this pull request
May 10, 2024
musl doesn't have res_n* functions so we are falling back to the not thread safe ones. Note that another approach was submitted at https://bugs.mysql.com/bug.php?id=106034 (mysql#385) but that is arguably less portable given it takes the new path for everything non-glibc where things may already work fine (e.g. Solaris). This patch is less invasive. Bug: https://bugs.gentoo.org/761352 See also: mysql#385 See also: https://bugs.mysql.com/bug.php?id=106034
parona-source
pushed a commit
to parona-source/mysql-server
that referenced
this pull request
Jun 7, 2024
musl doesn't have res_n* functions so we are falling back to the not thread safe ones. Note that another approach was submitted at https://bugs.mysql.com/bug.php?id=106034 (mysql#385) but that is arguably less portable given it takes the new path for everything non-glibc where things may already work fine (e.g. Solaris). This patch is less invasive. Bug: https://bugs.gentoo.org/761352 See also: mysql#385 See also: https://bugs.mysql.com/bug.php?id=106034
parona-source
pushed a commit
to parona-source/mysql-server
that referenced
this pull request
Jul 26, 2024
musl doesn't have res_n* functions so we are falling back to the not thread safe ones. Note that another approach was submitted at https://bugs.mysql.com/bug.php?id=106034 (mysql#385) but that is arguably less portable given it takes the new path for everything non-glibc where things may already work fine (e.g. Solaris). This patch is less invasive. Bug: https://bugs.gentoo.org/761352 See also: mysql#385 See also: https://bugs.mysql.com/bug.php?id=106034
parona-source
pushed a commit
to parona-source/mysql-server
that referenced
this pull request
Jan 9, 2025
musl doesn't have res_n* functions so we are falling back to the not thread safe ones. Note that another approach was submitted at https://bugs.mysql.com/bug.php?id=106034 (mysql#385) but that is arguably less portable given it takes the new path for everything non-glibc where things may already work fine (e.g. Solaris). This patch is less invasive. Bug: https://bugs.gentoo.org/761352 See also: mysql#385 See also: https://bugs.mysql.com/bug.php?id=106034
parona-source
pushed a commit
to parona-source/mysql-server
that referenced
this pull request
Jan 12, 2025
musl doesn't have res_n* functions so we are falling back to the not thread safe ones. Note that another approach was submitted at https://bugs.mysql.com/bug.php?id=106034 (mysql#385) but that is arguably less portable given it takes the new path for everything non-glibc where things may already work fine (e.g. Solaris). This patch is less invasive. Bug: https://bugs.gentoo.org/761352 See also: mysql#385 See also: https://bugs.mysql.com/bug.php?id=106034
parona-source
pushed a commit
to parona-source/mysql-server
that referenced
this pull request
May 14, 2025
musl doesn't have res_n* functions so we are falling back to the not thread safe ones. Note that another approach was submitted at https://bugs.mysql.com/bug.php?id=106034 (mysql#385) but that is arguably less portable given it takes the new path for everything non-glibc where things may already work fine (e.g. Solaris). This patch is less invasive. Bug: https://bugs.gentoo.org/761352 See also: mysql#385 See also: https://bugs.mysql.com/bug.php?id=106034
parona-source
pushed a commit
to parona-source/mysql-server
that referenced
this pull request
May 14, 2025
musl doesn't have res_n* functions so we are falling back to the not thread safe ones. Note that another approach was submitted at https://bugs.mysql.com/bug.php?id=106034 (mysql#385) but that is arguably less portable given it takes the new path for everything non-glibc where things may already work fine (e.g. Solaris). This patch is less invasive. Bug: https://bugs.gentoo.org/761352 See also: mysql#385 See also: https://bugs.mysql.com/bug.php?id=106034
parona-source
pushed a commit
to parona-source/mysql-server
that referenced
this pull request
Jul 22, 2025
musl doesn't have res_n* functions so we are falling back to the not thread safe ones. Note that another approach was submitted at https://bugs.mysql.com/bug.php?id=106034 (mysql#385) but that is arguably less portable given it takes the new path for everything non-glibc where things may already work fine (e.g. Solaris). This patch is less invasive. Bug: https://bugs.gentoo.org/761352 See also: mysql#385 See also: https://bugs.mysql.com/bug.php?id=106034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The musl C library does not support res_ninit, res_nsearch and
res_nclose. Check if res_ninit is defined, and use res_search if not.