Do not store temp data per-env #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This trips up the dependency tracker and outdatedness checker and can cause wrong compilation output.
|
This commit has the side effect of doing a full recompile each time the environment changes! In a normal workflow where you fix a typo on staging and then on production you now have to wait for two full recompiles... This makes working with large nanoc sites unbearably slow, can we please revert? |
|
A better solution to prevent issue #1067 would be to do a full recompile only if the output directories for the environments are the same. In normal use you would use two different output directories so the issue would not occur. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1067.