Let write nil always skip routing rule
#1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisdefreyne
force-pushed
the
write-nil
branch
2 times, most recently
from
8b8cf7a
to
f79bf90
Compare
denisdefreyne
force-pushed
the
write-nil
branch
from
f79bf90
to
e5bf21a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
The
skip_routing_rulewas properly set up, but somehow not used.If, after snapshot compaction, there is any path assigned to a snapshot action, the routing rule will be skipped. For example:
a, no pathsb, some pathsc, no pathsIn the example above, only for snapshot
cwould the routing rule be used (if any).To do
Related issues
Fixes #1374.