Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparisons #738

Merged
merged 1 commit into from Nov 28, 2015
Merged

Fix comparisons #738

merged 1 commit into from Nov 28, 2015

Conversation

denisdefreyne
Copy link
Member

  • Made comparing identifiers somewhat more strict (don’t blindly call #to_s)
  • Make Document equality less strict (don’t require the exact same class—a view also works)
  • Don’t crash when comparing an ItemRepView with something else (fixes Crash when comparing item reps #735).

@denisdefreyne denisdefreyne added this to the 4.0.1 milestone Nov 28, 2015
denisdefreyne added a commit that referenced this pull request Nov 28, 2015
@denisdefreyne
Merge pull request #738 from nanoc/fix-comparisons
fa59c47 
Fix comparisons
@denisdefreyne denisdefreyne merged commit fa59c47 into release-4.0.x Nov 28, 2015
@denisdefreyne denisdefreyne deleted the fix-comparisons branch November 28, 2015 09:59
@denisdefreyne denisdefreyne mentioned this pull request Nov 28, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type:bug 🐛
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@denisdefreyne