Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding a test for html doctype embeded in a <pre><code> #291

Closed
wants to merge 1 commit into from

Conversation

cmerot
Copy link

@cmerot cmerot commented Mar 22, 2013

When an item contains:

<pre><code>
#!html
&lt;!DOCTYPE html>
</code></pre>

with the relativize_paths filter, the result is messed up by the following code:

# FIXME cleanup because it is ugly
# # Because using the `Nokogiri::XML::DocumentFragment` class DOCTYPE 
# pseudonodes becomes even more creepy than usual.
result.sub!(/(!DOCTYPE.+?)(&gt;)/, '<\1>')

Is that still usefull?

@denisdefreyne
Copy link
Member

I don’t think this is necessary anymore. From what I can tell, it was necessary before because the relativize_paths filter used DocumentFragment, but it does no longer.

I’ll clean this up!

@denisdefreyne
Copy link
Member

See #296, which not only includes the test but also a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants