Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing styling, fixed a bug where the label would break #90

Closed
wants to merge 33 commits into from

Conversation

JorgenSolli
Copy link
Contributor

Referring to this PR #89
Now properly pointing from a separate branch to the master branch.

@emodric
Copy link
Member

emodric commented Jan 16, 2019

@JorgenSolli Thanks for the contribution and I'm so sorry for the late response, the past month has been hectic for me with lots of personal obligations.

Anyway, thanks for fixing this, however, it should've been opened against 3.3-release branch, since that branch is the current release branch, while master is a future version, but now stale :/

Would you be up to switching to 3.3 branch? You don't have to close the PR, you can just change the target branch in the PR settings and rabase on top of 3.3.

@emodric emodric mentioned this pull request Jan 16, 2019
@JorgenSolli JorgenSolli changed the base branch from master to 3.3-release January 16, 2019 14:28
@emodric
Copy link
Member

emodric commented Apr 2, 2019

Replaced by #95

@emodric emodric closed this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants