Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes and playing media icon. issue #38 #40

Merged
merged 32 commits into from Feb 5, 2021

Conversation

shapkarin
Copy link
Contributor

@shapkarin shapkarin commented Jan 31, 2020

  • Themes option
  • Dark theme
  • Icon to show if tab is playing media
  • Move input to left and make it larger
    • leave place for list edit icon, hope that later it will be implemented
  • Add logo and some info to the README
  • Update dependencies

#38

@shapkarin shapkarin changed the title Styled components Themes and playing media icon. issue #38 Jan 31, 2020
@nsand
Copy link
Owner

nsand commented Feb 1, 2020

Thanks for all the hard work on this, @shapkarin . I should have some time to look at the PR over the weekend.

@shapkarin
Copy link
Contributor Author

@nsand OK, feel free to share yours thoughts

@shapkarin
Copy link
Contributor Author

ping

@nsand
Copy link
Owner

nsand commented Feb 17, 2020

Hey, @shapkarin Sorry work has been crazy lately and some RL things have popped up on top of that. I'll try reviewing this soon.

@shapkarin
Copy link
Contributor Author

Got that. Thanks for the answer. Maybe I will add tests to this repo later.

@shapkarin
Copy link
Contributor Author

@nsand Hi, I recently found that with a real big list styled-components performs slower than previous tab-glutton version. I think I need to add this optimization #39 to the current PR.

@nsand
Copy link
Owner

nsand commented Feb 29, 2020

Thanks for considering perf in this! I’ll have some time this weekend to take a look.

@nsand
Copy link
Owner

nsand commented Mar 9, 2020

Hey, @shapkarin. I started looking at the changes and things are looking good so far. I haven't worked with styled-components yet, so I'm going to brush up on them a bit before continuing on. But just wanted to thank you for your patience while I review this.

@shapkarin
Copy link
Contributor Author

It looks like it's just a higher-order component. But I still think that we need to add something like react-window to produce the next stable release.

@shapkarin
Copy link
Contributor Author

shapkarin commented Mar 13, 2020

I will try to find time for #39 too.. and fell free to help me with that

@shapkarin
Copy link
Contributor Author

Hello @nsand can you please recheck this PR and approve with my changes extension still has enough performance for the new release. For the next one release I will find time to close the #39 with a new PR.

@shapkarin
Copy link
Contributor Author

Hello. It's about half of year I use my fork and don't get any problems with performance. I guess that my PR is fine.
Please have a look.

@nsand
Copy link
Owner

nsand commented Feb 5, 2021

Hello. It's about half of year I use my fork and don't get any problems with performance. I guess that my PR is fine.
Please have a look.

Thanks @shapkarin . I'm so sorry for this taking so long to get merged in. I appreciate your persistence and contribution! I hope you're doing well and staying healthy.

@nsand nsand merged commit 6bfd0d8 into nsand:master Feb 5, 2021
@shapkarin
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants