Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React Context Themes and playing media indication #38

Closed
3 tasks done
shapkarin opened this issue Jan 25, 2020 · 5 comments
Closed
3 tasks done

React Context Themes and playing media indication #38

shapkarin opened this issue Jan 25, 2020 · 5 comments

Comments

@shapkarin
Copy link
Contributor

shapkarin commented Jan 25, 2020 •
edited

Hello. Thanks for a nice extension.

I plan to add to it:

  • Themes with React Context (or with Styled-Components ThemeProvider)
  • Dark theme
  • Show (in list) what tab is playing media now

It's been a while since last comments and updates so I need to know are you able to review some changes.

Next it's I'll try to help with other enhancement from this repo. For example I like keyboard navigation and add other tab actions.

Also it's nice to save search and list state even if user close popup.
@nsand
Copy link
Owner

nsand commented Jan 26, 2020

Hi @shapkarin thanks for your interest and the kind words! I'd love to accept contributions to the project, and I'll certainly be available to review the changes. These all sound like great additions to me. Thanks so much for offering to help.

@shapkarin
Copy link
Contributor Author

shapkarin commented Jan 26, 2020 •
edited

Cool then :-) I did playing media indication. It's too raw now and I think about design)
Hope that at next week I will provide a PR with all my proposals.

@shapkarin shapkarin mentioned this issue Jan 26, 2020
Closed
shapkarin pushed a commit to shapkarin/tab-glutton that referenced this issue Jan 26, 2020
playing media indication nsand#38
b1e397a
shapkarin pushed a commit to shapkarin/tab-glutton that referenced this issue Jan 27, 2020
remove title nsand#38
4432e57
shapkarin pushed a commit to shapkarin/tab-glutton that referenced this issue Jan 28, 2020
add several styled-components [nsand#38]
86a7811
shapkarin pushed a commit to shapkarin/tab-glutton that referenced this issue Jan 28, 2020
basic theme switch nsand#38
db304bc
shapkarin pushed a commit to shapkarin/tab-glutton that referenced this issue Jan 28, 2020
more theming and todo nsand#38
f50575a
shapkarin pushed a commit to shapkarin/tab-glutton that referenced this issue Jan 28, 2020
more theming and todo nsand#38
4dd5611
shapkarin pushed a commit to shapkarin/tab-glutton that referenced this issue Jan 28, 2020
more theming and todo nsand#38
c1bedd9
@shapkarin
Copy link
Contributor Author

heh, I didn't expect that Github will track all squashes and fixups.. but I glad to say the soon I will prepare some new user settings for themes.

shapkarin pushed a commit to shapkarin/tab-glutton that referenced this issue Jan 28, 2020
migrate oprions to react [in progress] nsand#16 nsand#38
69e07bc
shapkarin pushed a commit to shapkarin/tab-glutton that referenced this issue Jan 28, 2020
basic theme switch at user options nsand#16 nsand#38
f115049
shapkarin pushed a commit to shapkarin/tab-glutton that referenced this issue Jan 28, 2020
basic theme switch at user options nsand#38
97b9981
@shapkarin
Copy link
Contributor Author

shapkarin commented Jan 30, 2020 •
edited

Almost done with my proposals. Just need to migrate tab-item, change separator color and fix current tab indication.
Снимок экрана 2020-01-30 в 19 10 29

You can find themes config at https://github.com/shapkarin/tab-glutton/blob/styled-components/src/themes.js

Also I have some design problems to solve.

Hope soon I will prepare the PR.

P.S.
I also migrate options page to React, to style with themes it too like in #16 and I'm not sure but maybe we can even render options inside the extension popup

shapkarin pushed a commit to shapkarin/tab-glutton that referenced this issue Jan 30, 2020
fix active tab indication nsand#38
f0b1ebb
shapkarin pushed a commit to shapkarin/tab-glutton that referenced this issue Jan 30, 2020
migrate tab-tem to styled components nsand#38
1a2c18f
@shapkarin shapkarin mentioned this issue Jan 31, 2020
Merged
shapkarin pushed a commit to shapkarin/tab-glutton that referenced this issue Oct 1, 2020
Styled components (#3)
2c7d961 
* playing media indication nsand#38

* remove title nsand#38

* add several styled-components [nsand#38]

* basic theme switch nsand#38

* more theming and todo nsand#38

* migrate oprions to react [in progress] nsand#16 nsand#38

* basic theme switch at user options nsand#38

* remove useless css rule

* migration to styled-components [in progress] & fix some admin options

* style body with theme, fix media icon, fix options

* default theme const

* fix active tab indication nsand#38

* fix pin

* migrate tab-tem to styled components nsand#38

* fixes

* fix typo

* fix options

* remove old comment

* theme section border

* change version and add contributors to package.json

* fix dense option

* reafct options

* fix options

* remove old options.js

* themes names uppercase

* add info to the README.md

* fix typo

* fix typo

* fix titles

* add getting started tutorial link

* rename readme link
nsand pushed a commit that referenced this issue Feb 5, 2021
Themes and playing media icon. issue #38 (#40)
6bfd0d8 
* playing media indication #38

* remove title #38

* add several styled-components [#38]

* basic theme switch #38

* more theming and todo #38

* migrate oprions to react [in progress] #16 #38

* basic theme switch at user options #38

* remove useless css rule

* migration to styled-components [in progress] & fix some admin options

* style body with theme, fix media icon, fix options

* default theme const

* fix active tab indication #38

* fix pin

* migrate tab-tem to styled components #38

* fixes

* fix typo

* fix options

* remove old comment

* theme section border

* change version and add contributors to package.json

* fix dense option

* reafct options

* fix options

* remove old options.js

* themes names uppercase

* add info to the README.md

* fix typo

* fix typo

* fix titles

* add getting started tutorial link

* rename readme link
@shapkarin
Copy link
Contributor Author

Closed with #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nsand @shapkarin