Skip to content

Commit

Permalink
Revert "Support for the Modern IME candidate list UI (used in Windows…
Browse files Browse the repository at this point in the history
… 8 and above for such input methods as Chinese Simplified Microsoft Pinyin)."

Unincubates #4011

This reverts commit dbbaace.

Note that this still incubates #4145
  • Loading branch information
michaelDCurran committed Jan 6, 2016
1 parent be8f9c3 commit 4e93c3c
Show file tree
Hide file tree
Showing 7 changed files with 6 additions and 43 deletions.
2 changes: 1 addition & 1 deletion include/espeak
2 changes: 1 addition & 1 deletion include/liblouis
Submodule liblouis updated 47 files
+2 −1 .gitignore
+43 −32 ANNOUNCEMENT
+0 −4 AUTHORS
+10 −4 Dockerfile
+1 −33 NEWS
+0 −17 README
+2 −6 configure.ac
+11 −37 doc/liblouis.texi
+1 −1 gnulib/Makefile.am
+1 −2 gnulib/m4/gnulib-cache.m4
+2 −2 gnulib/m4/gnulib-common.m4
+0 −3 gnulib/m4/gnulib-comp.m4
+0 −29 gnulib/m4/ld-output-def.m4
+0 −8 liblouis/Makefile.am
+55 −6 liblouis/compileTranslationTable.c
+1 −1 liblouis/findTable.c
+2 −2 liblouis/liblouis.h.in
+3 −8 liblouis/logging.c
+10 −41 liblouis/lou_backTranslateString.c
+40 −19 liblouis/lou_translateString.c
+9 −12 liblouis/louis.h
+0 −4 tables/Makefile.am
+0 −2 tables/hu-exceptionwords.cti
+0 −397 tables/mn-MN.utb
+0 −620 tables/no-no-8dot.utb
+0 −178 tables/no-no-chardefs6.uti
+177 −21 tables/no-no-g0.utb
+7 −39 tables/no-no-g2.ctb
+0 −558 tables/no-no-latinLetterDef6Dots_diacritics.uti
+2,639 −2,824 tables/zh-tw.ctb
+0 −11 tests/Makefile.am
+0 −264 tests/en-ueb-symbols_harness.yaml
+9 −13 tests/harness/Makefile.am
+0 −271 tests/harness/en-ueb-symbols_harness.txt
+0 −3,150 tests/harness/no_harness.txt
+0 −260 tests/harness/no_harness_8dot.txt
+0 −45 tests/harness/no_harness_g1.txt
+0 −50 tests/harness/no_harness_g2.txt
+0 −5 tests/mn-MN_harness.yaml
+0 −256 tests/no_8dot_harness.yaml
+0 −33 tests/no_g1_harness.yaml
+0 −35 tests/no_g2_harness.yaml
+0 −731 tests/no_harness.yaml
+2 −2 tools/gnulib/m4/gnulib-common.m4
+9 −42 tools/lou_trace.c
+1 −1 windows/Makefile.nmake
+2 −2 windows/include/liblouis.h
2 changes: 1 addition & 1 deletion miscDeps
Submodule miscDeps updated from 239621 to a7f918
6 changes: 1 addition & 5 deletions source/IAccessibleHandler.py
Expand Up @@ -566,9 +566,6 @@ def winEventCallback(handle,eventID,window,objectID,childID,threadID,timestamp):
window=tempWindow

windowClassName=winUser.getClassName(window)
# Modern IME candidate list windows fire menu events which confuse us and can't be used properly inconjunction with input composition support
if windowClassName=="Microsoft.IME.UIManager.CandidateWindow.Host" and eventID in MENU_EVENTIDS:
return
#At the moment we can't handle show, hide or reorder events on Mozilla Firefox Location bar,as there are just too many of them
#Ignore show, hide and reorder on MozillaDropShadowWindowClass windows.
if windowClassName.startswith('Mozilla') and eventID in (winUser.EVENT_OBJECT_SHOW,winUser.EVENT_OBJECT_HIDE,winUser.EVENT_OBJECT_REORDER) and childID<0:
Expand Down Expand Up @@ -781,8 +778,7 @@ def processDestroyWinEvent(window,objectID,childID):
# so can't use generic focus correction. (#2695)
focus=api.getFocusObject()
from NVDAObjects.IAccessible.mscandui import BaseCandidateItem
windowClassName=winUser.getClassName(window)
if childID==0 and isinstance(focus,BaseCandidateItem) and window==focus.windowHandle and not eventHandler.isPendingEvents("gainFocus"):
if objectID==0 and childID==0 and isinstance(focus,BaseCandidateItem) and window==focus.windowHandle and not eventHandler.isPendingEvents("gainFocus"):
obj=focus.container
if obj:
eventHandler.queueEvent("gainFocus",obj)
Expand Down
2 changes: 1 addition & 1 deletion source/NVDAObjects/IAccessible/__init__.py
Expand Up @@ -424,7 +424,7 @@ def findOverlayClasses(self,clsList):
parentWindow=winUser.getAncestor(self.windowHandle,winUser.GA_PARENT)
if parentWindow and winUser.getClassName(parentWindow)=="Frame Notification Bar":
clsList.append(IENotificationBar)
if windowClassName.lower().startswith('mscandui') or windowClassName in ("Microsoft.IME.CandidateWindow.View","Microsoft.IME.UIManager.CandidateWindow.Host"):
if windowClassName.lower().startswith('mscandui'):
import mscandui
mscandui.findExtraOverlayClasses(self,clsList)
elif windowClassName=="GeckoPluginWindow" and self.event_objectID==0 and self.IAccessibleChildID==0:
Expand Down
34 changes: 1 addition & 33 deletions source/NVDAObjects/IAccessible/mscandui.py
Expand Up @@ -212,42 +212,10 @@ def event_show(self):
item=MSCandUIWindow_candidateListItem(IAccessibleObject=self.IAccessibleObject,IAccessibleChildID=3)
reportSelectedCandidate(item)

class ModernCandidateUICandidateItem(BaseCandidateItem):

def _get_candidateCharacters(self):
return super(BaseCandidateItem,self).name

_candidateNumber=""

def _get_candidateNumber(self):
# The following property call sets candidateNumber
self.visibleCandidateItemsText
return self._candidateNumber

def _get_visibleCandidateItemsText(self):
textList=[]
index=1
for child in super(ModernCandidateUICandidateItem,self).parent.children:
if not isinstance(child,ModernCandidateUICandidateItem) or controlTypes.STATE_SELECTABLE not in child.states: continue
child.candidateNumber=index
textList.append(child.name)
if child.candidateCharacters==self.candidateCharacters:
self._candidateNumber=index
index+=1
if len(textList)<=1: return None
self.visibleCandidateItemsText=(u", ".join(textList))+u", "
return self.visibleCandidateItemsText

def event_stateChange(self):
if controlTypes.STATE_SELECTED in self.states:
reportSelectedCandidate(self)

def findExtraOverlayClasses(obj,clsList):
windowClassName=obj.windowClassName
role=obj.IAccessibleRole
if windowClassName=="Microsoft.IME.CandidateWindow.View" and obj.role==controlTypes.ROLE_BUTTON:
clsList.append(ModernCandidateUICandidateItem)
elif windowClassName=="MSCandUIWindow_Candidate":
if windowClassName=="MSCandUIWindow_Candidate":
if role==oleacc.ROLE_SYSTEM_CLIENT:
clsList.append(MSCandUIWindow)
elif role==oleacc.ROLE_SYSTEM_LISTITEM:
Expand Down
1 change: 0 additions & 1 deletion source/_UIAHandler.py
Expand Up @@ -33,7 +33,6 @@
UIA_SizeOfSetPropertyId=30153

badUIAWindowClassNames=[
"Microsoft.IME.CandidateWindow.View",
"SysTreeView32",
"WuDuiListView",
"ComboBox",
Expand Down

0 comments on commit 4e93c3c

Please sign in to comment.