Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caret move not responding after input method candidate window closed #4145

Closed
nvaccessAuto opened this issue May 17, 2014 · 5 comments
Closed

Caret move not responding after input method candidate window closed #4145

nvaccessAuto opened this issue May 17, 2014 · 5 comments
Assignees
@michaelDCurran
Labels
Asian character input bug/regression bug
Milestone
2016.1

Comments

@nvaccessAuto
Copy link

Reported by nishimotz on 2014-05-17 04:21
setup:

  • Windows 8.1 Update (64bit, User Interface Language: English, enabled Japanese Microsoft IME and SAPI5 Japanese Haruka Desktop TTS)
  • NVDA 2014.2rc1 (speak typed characters: enabled, automatically report all available candidates: disabled)
  • notepad.exe

procedure:

  • start notepad application
  • type "abc" with English keyboard array. each characters are reported as typed.
  • windows+space: switch to Japanese IME
  • application key, then upper arrow key twice: if the item is "Close IME", press Escape to cancel. if it is "Open IME", press Enter.
  • type "kawa" (reported 'k', 'ka', 'w', 'wa')
  • space key (reported 'kawa')
  • space key (opened candidate window and reported second candidate)
  • enter key (second candidate is selected.): expected to announce the selected candidate 'kawa'. actually only 'candidate' is announced.
  • left arrow key or right arrow key: expected to report the character at the caret. actually nothing reported.
  • alt key twice: now left or right arrow keys work normally.

As far as we know, Braille display is also not properly updated after the open-close of candidate window (although Japanese Braille is only supported by Japanese forked version of NVDA).

Reverting api.py line 96 regarding #3873 (setFocusObject incorrectly caches container property as parent) seems to resolve the issues as far as we investigated.
@nvaccessAuto
Copy link
Author

Comment 2 by vgjh2005 on 2014-08-14 08:57
Hi：
This problem is caused in Chinese input method. I also hope that can be solve as soon as possible.
Thanks

@nvaccessAuto
Copy link
Author

Comment 3 by surfer0627 on 2014-08-26 01:32
Thanks nishimotz.

This ticket provides a more specific description than the previous one I have filed #2792.

I also hope that this case could be fixed in the near future.

@nvaccessAuto
Copy link
Author

Comment 4 by jteh (in reply to comment 3) on 2014-08-26 02:41
Replying to surfer0627:

This ticket provides a more specific description than the previous one I have filed #2792.

While #2792 results in the same problem, I think it's actually a different cause, as @nishimotz noted that the issue he is reporting was caused by a fairly recent change (01e2298), whereas #2792 was filed long before that.

@nvaccessAuto
Copy link
Author

Comment 5 by surfer0627 on 2014-08-26 06:19
Thanks Jamie's clarification.

michaelDCurran added a commit that referenced this issue Dec 10, 2015
@michaelDCurran
Support for the Modern IME candidate list UI (used in Windows 8 and a…
2370692 
…bove for such input methods as Chinese Simplified Microsoft Pinyin).

Fixes #4145
Fixes #4011
michaelDCurran added a commit that referenced this issue Dec 10, 2015
@michaelDCurran
Support for the Modern IME candidate list UI (used in Windows 8 and a…
dbbaace 
…bove for such input methods as Chinese Simplified Microsoft Pinyin).

Fixes #4145
Fixes #4011
@michaelDCurran
Copy link
Member

Fix implemented as part of #4011

michaelDCurran added a commit that referenced this issue Jan 6, 2016
@michaelDCurran
Revert "Support for the Modern IME candidate list UI (used in Windows…
4e93c3c 
… 8 and above for such input methods as Chinese Simplified Microsoft Pinyin)."

Unincubates #4011

This reverts commit dbbaace.

Note that this still incubates #4145
@jcsteh jcsteh added this to the 2016.1 milestone Jan 6, 2016
@jcsteh jcsteh mentioned this issue Jan 7, 2016
Closed
larry801 pushed a commit to larry801/nvda that referenced this issue Aug 13, 2018
@michaelDCurran @jiangtiandao
Support for the Modern IME candidate list UI (used in Windows 8 and a…
999850f 
…bove for such input methods as Chinese Simplified Microsoft Pinyin).

Fixes nvaccess#4145
Fixes nvaccess#4011
@larry801 larry801 mentioned this issue Aug 14, 2018
Merged
michaelDCurran pushed a commit that referenced this issue Jun 24, 2019
@larry801 @LeonarddeR @michaelDCurran
Add support for input methods as Chinese Simplified Microsoft Pinyin …
e03e697 
…and Microsoft Wubi (#8621)

* Support for the Modern IME candidate list UI (used in Windows 8 and above for such input methods as Chinese Simplified Microsoft Pinyin).

Fixes #4145
Fixes #4011

* Fix focus move issue

* Window handle of ModernCandidateUI destory event is not the same as host application.Use className CiceroUIWndFrame

* Move get windows class into first if

* Use another class name found in log for stability CireoWndFrame
sometimes does not appear

* Fix double reading after ending inputComposition

* Add Microsoft Quick support

* Correct focus in NVDAHelper since OBJ_HIDE events cannot be detected in NVDA find dialog

* fix strange double NVDAHelper.py

* fix confiicts caused by line ending

* Correct focus fix

* Turn off autocrlf

* fix line ending problem

* Restore old msaa focus correction

* Fix merge issue

* merge master

* Split long comments

Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>

* Split long if statement to lines

Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>

* Split comments

Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>

* Use standalone focus correction logic for ModernCandidate

* Call  _get_parent in NVDAObject.window directly

Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>

* Remove debug logging

* Merge two if statement and split into lines

* Fix missing imports

* Optimize imports

* Remove redundant import

* Add comment for why candidate window is considered bad

* Refresh candidate item on its own so that we do not touch property of other objects

* Fix line endings for NVDAHelper.py

* Fix line endings for NVDAObjects/IAccessible/__init__.py

* Fix line endings of NVDAObjects/IAccessible/mscandui.py

* Fix line endings for _UIAHandler.py

* Fix typo in comments

Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelDCurran michaelDCurran

Labels
Asian character input bug/regression bug
Projects
None yet
Milestone
2016.1
Development

No branches or pull requests
3 participants
@jcsteh @michaelDCurran @nvaccessAuto