Support IA2_ROLE_BLOCK_QUOTE. (#8577)

* Support IA2_ROLE_BLOCK_QUOTE. This allows the new ARIA role="blockquote" to be supported in Firefox 63. Also, Firefox 63 exposes HTML blockquote with this role. Without this change, object navigation reports "unknown" for HTML blockquote. * Update what's new * Gecko_ia2 virtualBuffer: support jumping to ARIA blockquotes with quicknav.
nvaccess · Jul 31, 2018 · 5b80fca · 5b80fca
1 parent 870669e
commit 5b80fca
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/source/IAccessibleHandler.py b/source/IAccessibleHandler.py
@@ -254,6 +254,7 @@ def flushEvents(self):
 	IA2_ROLE_VIEW_PORT:controlTypes.ROLE_VIEWPORT,
 	IA2_ROLE_CONTENT_DELETION:controlTypes.ROLE_DELETED_CONTENT,
 	IA2_ROLE_CONTENT_INSERTION:controlTypes.ROLE_INSERTED_CONTENT,
+	IA2_ROLE_BLOCK_QUOTE:controlTypes.ROLE_BLOCKQUOTE,
 	#some common string roles
 	"frame":controlTypes.ROLE_FRAME,
 	"iframe":controlTypes.ROLE_INTERNALFRAME,

diff --git a/source/virtualBuffers/gecko_ia2.py b/source/virtualBuffers/gecko_ia2.py
@@ -269,7 +269,12 @@ def _searchableAttribsForNodeType(self,nodeType):
 		elif nodeType=="graphic":
 			attrs={"IAccessible::role":[oleacc.ROLE_SYSTEM_GRAPHIC]}
 		elif nodeType=="blockQuote":
-			attrs={"IAccessible2::attribute_tag":self._searchableTagValues(["blockquote"])}
+			attrs=[
+				# Search for a tag of blockquote for older implementations before the blockquote IAccessible2 role existed.
+				{"IAccessible2::attribute_tag":self._searchableTagValues(["blockquote"])},
+				# Also support the new blockquote IAccessible2 role
+				{"IAccessible::role":[IAccessibleHandler.IA2_ROLE_BLOCK_QUOTE]},
+			]
 		elif nodeType=="focusable":
 			attrs={"IAccessible::state_%s"%oleacc.STATE_SYSTEM_FOCUSABLE:[1]}
 		elif nodeType=="landmark":

diff --git a/user_docs/en/changes.t2t b/user_docs/en/changes.t2t
@@ -19,6 +19,7 @@ What's New in NVDA
  - You can enable this feature by selecting the automatic option from the list of braille displays in NVDA's braille display selection dialog.
  - Please consult the documentation for additional details.
 - Added support for various modern input features introduced in recent Windows 10 releases. These include emoji panel (Fall Creators Update), dictation (Fall Creators Update), hardware keyboard input suggestions (April 2018 Update), and cloud clipboard (RS5). (#7273)
+- Content marked as a block quote using ARIA (role blockquote) is now supported in Mozilla Firefox 63. (#8577)
 
 
 == Changes ==