New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in edge, this page will freeze NVDA forever #7143
Comments
Any chance this will be looked into soon? I want to change wordpress themes, should I yank this code into a separate page? |
CC @michaelDCurran. Would you be able to take a quick look at this some time soon before the test case disappears? |
I promise to take a look at this tomorrow morning (my time). And leading on from investigating this, I will change the number-specific heading quicknav code to search by attribute value of specific heading type, rather than the generalized paragraph search for all headings, as this will be faster in the specific number case. |
Some further notes: |
PR #7341 fixes an NVDA bug which addresses the issues here. However, there does still seem to be a bug in Edge that was partly to blame for the issue. Specifically: |
Sweet! Thanks for taking a look.
…On Thu, Jun 29, 2017 at 6:57 PM, Michael Curran ***@***.***> wrote:
PR #7341 <#7341> fixes an NVDA bug
which addresses the issues here. However, there does still seem to be a bug
in Edge that was partly to blame for the issue. Specifically:
When moving by line down the page, after getting to the "NVDA development"
link, moving by line lands you on some kind of blank link. At least, NVDA
announces it as a link. Yet, checking the navigator object after that (i.e.
caling UIA's getEnclosingElement) after the fact, yeields some kind of
graphic, at the very end of the entire document. In deed it is the deepest
last child. Due to a bug in the way we were choosing to jump over certain
content to handle ARIA-label etc, we were then jumping over this graphic
and landing on the bottom line. I'm guessing that the link disappears and
Edge is falling back to giving back the final node in the document.
Either way, it showed up the other bug which I was able to fix.
Also, I can reproduce the bugs on a locally saved copy of the page, thus
@derekriemer <https://github.com/derekriemer> you are free to change your
site now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7143 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFGivdp__uNsUnMdZdDIS1LE0-_7XMJ1ks5sJEgNgaJpZM4NRA25>
.
--
Derek Riemer: Improving the world one byte at a time!
- University of Colorado Boulder Department of computer science, 4th
year undergraduate student.
- Accessibility enthusiast.
- Proud user of the NVDA screen reader.
- Open source enthusiast.
- Skier.
Personal website <http://derekriemer.com>
|
Note: this needs to be looked at fairly soon, as I want to change my theme back to the 2015 theme because I like its accessibility much better. I am keeping it for now so you guys can look at it
I'm sorry, I spent about half an hour trying to get this to a small test that made sense, and I couldn't get it to work on a smaller page. I don't know what is going on here.
The text was updated successfully, but these errors were encountered: