Fix up support of jumping over replaced content (ARIA label etc) when reading in Edge #7341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… reading in Edge. * EdgeTextInfo.UIAElementAtStartWithReplacedContent: Ensure the element we have found in the ancestry does include a valid name, as if it has none, we'd never use it to replace content anyway. This will stop (sometimes large) chunks of the page from being non-navigable. * EdgeTextInfo._moveToEdgeOfReplacedContent: Correct logic so that we really land on the edge of replaced content. Previously this would cause the first character after the replaced content to be skipped, and also cause you to be stuck on the first character of the replaced content when moving previous character out of it. The old logic may have been confused by very old builds of Edge with bugs pre Creators Update.
feerrenrut
reviewed
Jul 4, 2017
| name=element.getCachedPropertyValue(UIAHandler.UIA_NamePropertyId) | ||
| if name: | ||
| ariaProperties=element.getCachedPropertyValue(UIAHandler.UIA_AriaPropertiesPropertyId) | ||
| if ('label=' in ariaProperties) or ('labelledby=' in ariaProperties): |
There was a problem hiding this comment.
while here it might be worth checking for these via EdgeNode._get_ariaProperties or perhaps using splitUIAElementAttribs
There was a problem hiding this comment.
This is a raw UIAElement rather than an NVDAObject, so _get_ariaProperties is not available here.
I could use splitUIAElementAttribs but I'm not too sure its worth the extra processing time where I don't really need the values nor anything else other than checking for those 2 specific keys.
feerrenrut
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7143
EdgeTextInfo.UIAElementAtStartWithReplacedContent: Ensure the element we have found in the ancestry does include a valid name, as if it has none, we'd never use it to replace content anyway. This will stop (sometimes large) chunks of the page from being non-navigable.
EdgeTextInfo._moveToEdgeOfReplacedContent: Correct logic so that we really land on the edge of replaced content. Previously this would cause the first character after the replaced content to be skipped, and also cause you to be stuck on the first character of the replaced content when moving previous character out of it. The old logic may have been confused by very old builds of Edge with bugs pre Creators Update.
These changes address all the problems mentioned in the summary of Issue #7143 I.e.:
On the page mentioned: