New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in edge, this page will freeze NVDA forever #7143

Closed
derekriemer opened this Issue May 4, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@derekriemer
Collaborator

derekriemer commented May 4, 2017

Note: this needs to be looked at fairly soon, as I want to change my theme back to the 2015 theme because I like its accessibility much better. I am keeping it for now so you guys can look at it

  1. in edge, visit https://derekriemer.com
  2. press h from the top. Note that you never reach the headings in the main landmark.
  3. go to the bottom of the page.
  4. press shift+h several times. Note that NVDA gets stuck in a cycle between heading level twos (Home and Derek Riemer).
  5. Note that if you press shift+1, NVDA gets stuck in the infinite loop forever.

I'm sorry, I spent about half an hour trying to get this to a small test that made sense, and I couldn't get it to work on a smaller page. I don't know what is going on here.

@jcsteh jcsteh added the Edge label May 4, 2017

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer Jun 28, 2017

Collaborator

Any chance this will be looked into soon? I want to change wordpress themes, should I yank this code into a separate page?

Collaborator

derekriemer commented Jun 28, 2017

Any chance this will be looked into soon? I want to change wordpress themes, should I yank this code into a separate page?

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Jun 28, 2017

Contributor

CC @michaelDCurran. Would you be able to take a quick look at this some time soon before the test case disappears?

Contributor

jcsteh commented Jun 28, 2017

CC @michaelDCurran. Would you be able to take a quick look at this some time soon before the test case disappears?

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Jun 28, 2017

Contributor

I promise to take a look at this tomorrow morning (my time). And leading on from investigating this, I will change the number-specific heading quicknav code to search by attribute value of specific heading type, rather than the generalized paragraph search for all headings, as this will be faster in the specific number case.

Contributor

michaelDCurran commented Jun 28, 2017

I promise to take a look at this tomorrow morning (my time). And leading on from investigating this, I will change the number-specific heading quicknav code to search by attribute value of specific heading type, rather than the generalized paragraph search for all headings, as this will be faster in the specific number case.

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Jun 29, 2017

Contributor

Some further notes:
When moving down the page from the top, either with arrow keys or review cursor, after the "NVDA development" line in the "Other" submenu on the navbar, you then jump straight to the blank line above "Powered by Wordpress" at the bottom of the page. However, when moving back up, you go through all the main content. Also, if you move by character or word off the end of the "NVDA development" link, you hit another link called "scroll to content" and then you can move into and down the main content by any means, including by line.
As you can not get to this content moving down by line (or paragraph I assume), the means we use to find the next heading will also fail here, thus why you cannot get to any further headings.
The loop when going previous heading with shift+h (between Home and Derek) is either a bug in NVDA or Edge - I need to investigate further, but may still be related to the above issue.

Contributor

michaelDCurran commented Jun 29, 2017

Some further notes:
When moving down the page from the top, either with arrow keys or review cursor, after the "NVDA development" line in the "Other" submenu on the navbar, you then jump straight to the blank line above "Powered by Wordpress" at the bottom of the page. However, when moving back up, you go through all the main content. Also, if you move by character or word off the end of the "NVDA development" link, you hit another link called "scroll to content" and then you can move into and down the main content by any means, including by line.
As you can not get to this content moving down by line (or paragraph I assume), the means we use to find the next heading will also fail here, thus why you cannot get to any further headings.
The loop when going previous heading with shift+h (between Home and Derek) is either a bug in NVDA or Edge - I need to investigate further, but may still be related to the above issue.

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Jun 30, 2017

Contributor

PR #7341 fixes an NVDA bug which addresses the issues here. However, there does still seem to be a bug in Edge that was partly to blame for the issue. Specifically:
When moving by line down the page, after getting to the "NVDA development" link, moving by line lands you on some kind of blank link. At least, NVDA announces it as a link. Yet, checking the navigator object after that (i.e. caling UIA's getEnclosingElement) after the fact, yeields some kind of graphic, at the very end of the entire document. In deed it is the deepest last child. Due to a bug in the way we were choosing to jump over certain content to handle ARIA-label etc, we were then jumping over this graphic and landing on the bottom line. I'm guessing that the link disappears and Edge is falling back to giving back the final node in the document.
Either way, it showed up the other bug which I was able to fix.
Also, I can reproduce the bugs on a locally saved copy of the page, thus @derekriemer you are free to change your site now.

Contributor

michaelDCurran commented Jun 30, 2017

PR #7341 fixes an NVDA bug which addresses the issues here. However, there does still seem to be a bug in Edge that was partly to blame for the issue. Specifically:
When moving by line down the page, after getting to the "NVDA development" link, moving by line lands you on some kind of blank link. At least, NVDA announces it as a link. Yet, checking the navigator object after that (i.e. caling UIA's getEnclosingElement) after the fact, yeields some kind of graphic, at the very end of the entire document. In deed it is the deepest last child. Due to a bug in the way we were choosing to jump over certain content to handle ARIA-label etc, we were then jumping over this graphic and landing on the bottom line. I'm guessing that the link disappears and Edge is falling back to giving back the final node in the document.
Either way, it showed up the other bug which I was able to fix.
Also, I can reproduce the bugs on a locally saved copy of the page, thus @derekriemer you are free to change your site now.

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer Jul 1, 2017

Collaborator
Collaborator

derekriemer commented Jul 1, 2017

@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment