Update espeak-ng to most recent release 1.49.1 #7280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feerrenrut
added a commit
that referenced
this pull request
Jun 14, 2017
feerrenrut
added a commit
that referenced
this pull request
Jun 28, 2017
Espeak-ng has been updated to release 1.49.1 (#7280).
michaelDCurran
added a commit
that referenced
this pull request
Aug 17, 2017
This reverts commit 37fdb3b. Compiling espeakNG 1.49.1 as a release build causes compiling of the 'ar' dictionary to fail. This was reported to espeak in espeak-ng/espeak-ng#287
|
This pr had to be reverted in a6efeab as when building the rc (which is compiled as a release), the 'ar' dictionary failed to compile. This is most likely related to espeak-ng/espeak-ng#287 |
michaelDCurran
pushed a commit
that referenced
this pull request
Aug 17, 2017
|
Slight false alarm. In the end we were able to get a release build made with espeak 1.49.1. However, it is hit and miss as to whether it fails or not. Before 2017.4 we must switch to an espeak-ng build with the fixes for espeak-ng/espeak-ng#287 |
|
Is this going to build for 17.3? |
|
The build fails intermittently. However we know it can succeed. When it
comes time for the release, it simply may need to be built multiple
times. Certainly not a great position to be in, but later builds of
espeak-ng no longer have the issue we know, so we will ensure we upgrade
for 2017.4.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
See comment #7115 (comment)
Summary of the issue:
The goal is to incubate the most recent release of Espeak-ng, to test for stability. Ideally this can then be merged to master (which is using an arbitrary espeak commit from the 10th of Jan). The 1.49.1 release was made on Jan 22nd.
Testing performed:
Built NVDA locally, smoke tested by setting espeak as the synth, and moving through a few applications / web pages. Only tested with English.
Change log entry:
Changes:
Espeak-ng has been updated to release 1.49.1.