User guide and what's new for 2017.3: spelling fixes, grammar changes, making user guide friendlier, edits to what's new. re #7371 #7373

josephsl · 2017-07-11T00:45:58Z

Hi,

Resolves the following:

Fixes Spelling Errors in User guide #7371: numerous issues in user guide such as spelling inconsistencies, making user guide friendlier, term changes, capitalizations.
What's new edits.

Thanks.

…nvaccess#7371. Changes include: * Added 'Welcome to NVDA!' at the beginning of the user guide to make it even friendlier. * Realising: realizing. * Licence: license. * Organised: organized. * Combobox: combo box. * Capitalized features list and language names.

nvaccess#7371.

jcsteh

Thanks! A few comments:

You mention What's New edits, but I don't see any. Did you forget to push them?
Would you mind fixing the misspelling of "Tells" as "Tels" at around line 2343?
See two other review comments below.

jcsteh · 2017-07-11T01:21:02Z

user_docs/en/userGuide.t2t

@@ -8,17 +8,18 @@ NVDA NVDA_VERSION User Guide
 %%toc

 + Introduction +
+Welcome to NVDA!


Please add a blank line after this so it's in a paragraph by itself.

jcsteh · 2017-07-11T01:21:39Z

user_docs/en/userGuide.t2t

@@ -247,7 +248,7 @@ When the menu comes up, You can use the arrow keys to navigate the menu, and the
 | Toggle Input Help Mode | NVDA+1 | NVDA+1 | none | Pressing any key in this mode will report the key, and the description of any NVDA command associated with it |
 | Quit NVDA | NVDA+q | NVDA+q | none | Exits NVDA |
 | Pass next key through | NVDA+f2 | NVDA+f2 | none | Tells NVDA to pass the next key press straight through to the active application, even if it is normally treated as an NVDA key command |
-| Toggle application sleep mode on and off | NVDA+shift+s | NVDA+shift+z | none | sleep mode disables all NVDA commands and speech/braille output for the current application. This is most useful in applications that provide their own speech or screen reading features. Press this command again to disable self voicing mode. |
+| Toggle application sleep mode on and off | NVDA+shift+s | NVDA+shift+z | none | sleep mode disables all NVDA commands and speech/braille output for the current application. This is most useful in applications that provide their own speech or screen reading features. Press this command again to disable self-voicing mode. |


I think "self-voicing mode" here should be "sleep mode", as we're calling it two different things otherwise.

josephsl · 2017-07-11T02:19:43Z

Hi, what's new to be done after addressing user guide reviews, and thanks for reminding me about "tels" issue. Thanks.

…

----- Original Message ----- From: James Teh <notifications@github.com To: nvaccess/nvda <nvda@noreply.github.com Date sent: Tue, 11 Jul 2017 01:23:30 +0000 (UTC) Subject: Re: [nvaccess/nvda] User guide and what's new for 2017.3: spellingfixes, grammar changes, making user guide friendlier, edits to what's new. re#7371 (#7373) jcsteh requested changes on this pull request. Thanks! A few comments: 1. You mention What's New edits, but I don't see any. Did you forget to push them? 2. Would you mind fixing the misspelling of "Tells" as "Tels" at around line 2343? 3. See two other review comments below. @@ -8,17 +8,18 @@ NVDA NVDA_VERSION User Guide %%toc + Introduction + +Welcome to NVDA! Please add a blank line after this so it's in a paragraph by itself. @@ -247,7 +248,7 @@ When the menu comes up, You can use the arrow keys to navigate the menu, and the | Toggle Input Help Mode | NVDA+1 | NVDA+1 | none | Pressing any key in this mode will report the key, and the description of any NVDA command associated with it | | Quit NVDA | NVDA+q | NVDA+q | none | Exits NVDA | | Pass next key through | NVDA+f2 | NVDA+f2 | none | Tells NVDA to pass the next key press straight through to the active application, even if it is normally treated as an NVDA key command | -| Toggle application sleep mode on and off | NVDA+shift+s | NVDA+shift+z | none | sleep mode disables all NVDA commands and speech/braille output for the current application. This is most useful in applications that provide their own speech or screen reading features. Press this command again to disable self voicing mode. | +| Toggle application sleep mode on and off | NVDA+shift+s | NVDA+shift+z | none | sleep mode disables all NVDA commands and speech/braille output for the current application. This is most useful in applications that provide their own speech or screen reading features. Press this command again to disable self-voicing mode. | I think "self-voicing mode" here should be "sleep mode", as we're calling it two different things otherwise.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #7373 (review) 1512

… > sleep mode. re nvaccess#7371. Reviewed by Jamie Teh (NV Access): * Tels -> tells * Self-voicing > sleep mode * Welcome text is on its own paragraph.

jcsteh · 2017-07-11T02:49:06Z

user_docs/en/changes.t2t

@@ -8,9 +8,9 @@
 == New Features ==
 - A Braille setting has been added to "show messages indefinitely". (#6669)
 - In Microsoft Outlook message lists, report if a message is flagged. (#6374)
- In Microsoft Powerpoint, the exact type of a shape is now reported when editing a slide (Examples include: triangle, circle, video, arrow), rather than just 'shape'. (#7111)
+- In Microsoft PowerPoint, the exact type of a shape is now reported when editing a slide (Examples include: triangle, circle, video, arrow), rather than just 'shape'. (#7111)


This "examples include" thing is a bit weird linguistically. Maybe we could change it to this:

- In Microsoft PowerPoint, the exact type of a shape is now reported when editing a slide (such as triangle, circle, video or arrow), rather than just "shape". (#7111)

jcsteh · 2017-07-11T02:56:32Z

user_docs/en/changes.t2t

 - Mathematical content (provided as MathML) is now supported in Google Chrome. (#7184)
- NVDA can now speak using the new Windows OneCore voices (also known as mobile voices) included in Windows 10. You access these by selecting Windows OneCore voices in NVDA's Synthesizer dialog. (#6159)
+- NVDA can now speak using the new Windows OneCore voices (also known as SAPI5 Mobile voices) included in Windows 10. You access these by selecting Windows OneCore voices in NVDA's Synthesizer dialog. (#6159)


No one calls these SAPI5 Mobile apart from an old NVDA driver. Also, the voices were previously named "Mobile"; e.g. "Microsoft Zira Mobile". I don't think SAPI5 should be mentioned here.

jcsteh · 2017-07-11T02:58:06Z

user_docs/en/changes.t2t

@@ -37,7 +37,7 @@
 - "form": "frm"
 - "region": "rgn"
 - Example: "navigation landmark" becomes "lmk nav"
- Espeak-ng has been updated to release 1.49.1 (#7280).
+- Updated Espeak-ng to 1.49.1. (#7280).


This should be written "eSpeak NG" as is the official title of the project.

Please remove trailing full stop at end of line.

josephsl · 2017-07-11T03:11:13Z

Hi, done. For item 3, Reef’s work. Thanks. From: James Teh [mailto:notifications@github.com] Sent: Monday, July 10, 2017 8:00 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com> Subject: Re: [nvaccess/nvda] User guide and what's new for 2017.3: spelling fixes, grammar changes, making user guide friendlier, edits to what's new. re #7371 (#7373) @jcsteh requested changes on this pull request.

_____ In user_docs/en/changes.t2t <#7373 (comment)> :

@@ -8,9 +8,9 @@

== New Features == - A Braille setting has been added to "show messages indefinitely". (#6669) - In Microsoft Outlook message lists, report if a message is flagged. (#6374) -- In Microsoft Powerpoint, the exact type of a shape is now reported when editing a slide (Examples include: triangle, circle, video, arrow), rather than just 'shape'. (#7111) +- In Microsoft PowerPoint, the exact type of a shape is now reported when editing a slide (Examples include: triangle, circle, video, arrow), rather than just 'shape'. (#7111) This "examples include" thing is a bit weird linguistically. Maybe we could change it to this: - In Microsoft PowerPoint, the exact type of a shape is now reported when editing a slide (such as triangle, circle, video or arrow), rather than just "shape". (#7111)

_____ In user_docs/en/changes.t2t <#7373 (comment)> :

- Mathematical content (provided as MathML) is now supported in Google Chrome. (#7184)

-- NVDA can now speak using the new Windows OneCore voices (also known as mobile voices) included in Windows 10. You access these by selecting Windows OneCore voices in NVDA's Synthesizer dialog. (#6159) +- NVDA can now speak using the new Windows OneCore voices (also known as SAPI5 Mobile voices) included in Windows 10. You access these by selecting Windows OneCore voices in NVDA's Synthesizer dialog. (#6159) No one calls these SAPI5 Mobile apart from an old NVDA driver. Also, the voices were previously named "Mobile"; e.g. "Microsoft Zira Mobile". I don't think SAPI5 should be mentioned here.

_____ In user_docs/en/changes.t2t <#7373 (comment)> :

@@ -37,7 +37,7 @@

- "form": "frm" - "region": "rgn" - Example: "navigation landmark" becomes "lmk nav" -- Espeak-ng has been updated to release 1.49.1 (#7280). +- Updated Espeak-ng to 1.49.1. (#7280). 1. This should be written "eSpeak NG" as is the official title of the project. 2. Please remove trailing full stop at end of line. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7373 (review)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkGn6LPyt1ewrijKyqHvOY-oj3733ks5sMuU2gaJpZM4OTlqN> .

derekriemer · 2017-07-11T03:34:40Z

If a dialog contains a progress bar, the dialog text is now updated when the progress bar changes. This means, for example, that the remaining time can now be read in NVDA's "Downloading Update" dialog. (Braille doesn't refresh when downloading update #6862)
should this be for braille?

josephsl · 2017-07-11T03:36:05Z

@DavyKager, any thoughts on this entry? From: Derek Riemer [mailto:notifications@github.com] Sent: Monday, July 10, 2017 8:35 PM To: nvaccess/nvda <nvda@noreply.github.com> Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com> Subject: Re: [nvaccess/nvda] User guide and what's new for 2017.3: spelling fixes, grammar changes, making user guide friendlier, edits to what's new. re #7371 (#7373) * If a dialog contains a progress bar, the dialog text is now updated when the progress bar changes. This means, for example, that the remaining time can now be read in NVDA's "Downloading Update" dialog. (#6862 <#6862> ) should this be for braille? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7373 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkB-wJAZdW81j_ZrSFuoWyFmBenGNks5sMu1RgaJpZM4OTlqN> .

jcsteh · 2017-07-11T05:01:44Z

@derekriemer commented on 11 Jul 2017, 13:34 GMT+10:

If a dialog contains a progress bar, the dialog text is now updated when the progress bar changes.

My bad; this should be "the dialog text is updated in braille when...".

jcsteh · 2017-07-11T05:02:54Z

@josephsl commented on 11 Jul 2017, 13:11 GMT+10:

Hi, done. For item 3, Reef’s work. Thanks.

I know. I'm just more linguistically pedantic. There's a reason I normally review the What's New thoroughly just before release freeze. :)

josephsl added 2 commits July 10, 2017 17:36

User guide: appModules > settings and add-ons to make it friendlier. re

c18f078

nvaccess#7371.

jcsteh mentioned this pull request Jul 11, 2017

User guide: add "Welcome to NVDA!" at the beginning to make it friendlier. Offshoot of #7371. #7374

Closed

jcsteh requested changes Jul 11, 2017

View reviewed changes

josephsl added 2 commits July 10, 2017 19:29

User guide: tels -> tells, welcome text on its own line, self-voicing…

710be4a

… > sleep mode. re nvaccess#7371. Reviewed by Jamie Teh (NV Access): * Tels -> tells * Self-voicing > sleep mode * Welcome text is on its own paragraph.

What's new: entry fixes, mostly linguistic fixes and capitalization.

d90118e

jcsteh requested changes Jul 11, 2017

View reviewed changes

What's new: linguistic fixes suggested by Jamie Teh *NV Access).

290efc8

Two further fixes to What's New.

bfc994a

jcsteh approved these changes Jul 11, 2017

View reviewed changes

jcsteh merged commit caeb192 into nvaccess:master Jul 11, 2017

nvaccessAuto added this to the 2017.3 milestone Jul 11, 2017

jcsteh mentioned this pull request Sep 5, 2017

Virtual buffer skips check box in Chrome #6781

Closed

josephsl deleted the 17.3docs branch July 19, 2020 22:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

User guide and what's new for 2017.3: spelling fixes, grammar changes, making user guide friendlier, edits to what's new. re #7371 #7373

User guide and what's new for 2017.3: spelling fixes, grammar changes, making user guide friendlier, edits to what's new. re #7371 #7373

josephsl commented Jul 11, 2017 •

edited by jcsteh

jcsteh left a comment

jcsteh Jul 11, 2017

jcsteh Jul 11, 2017

josephsl commented Jul 11, 2017 via email

jcsteh Jul 11, 2017

jcsteh Jul 11, 2017

jcsteh Jul 11, 2017

josephsl commented Jul 11, 2017 via email

derekriemer commented Jul 11, 2017

josephsl commented Jul 11, 2017 via email

jcsteh commented Jul 11, 2017

jcsteh commented Jul 11, 2017

User guide and what's new for 2017.3: spelling fixes, grammar changes, making user guide friendlier, edits to what's new. re #7371 #7373

User guide and what's new for 2017.3: spelling fixes, grammar changes, making user guide friendlier, edits to what's new. re #7371 #7373

Conversation

josephsl commented Jul 11, 2017 • edited by jcsteh

jcsteh left a comment

Choose a reason for hiding this comment

jcsteh Jul 11, 2017

Choose a reason for hiding this comment

jcsteh Jul 11, 2017

Choose a reason for hiding this comment

josephsl commented Jul 11, 2017 via email

jcsteh Jul 11, 2017

Choose a reason for hiding this comment

jcsteh Jul 11, 2017

Choose a reason for hiding this comment

jcsteh Jul 11, 2017

Choose a reason for hiding this comment

josephsl commented Jul 11, 2017 via email

derekriemer commented Jul 11, 2017

josephsl commented Jul 11, 2017 via email

jcsteh commented Jul 11, 2017

jcsteh commented Jul 11, 2017

josephsl commented Jul 11, 2017 •

edited by jcsteh