Invalid regex expressions in dictionaries no longer causes crash. #6136
Conversation
|
@michaelDCurran Mind taking a look at this? |
|
When loading a SpeechDict, we could have individual DictionaryEntry lines ignored if they are invalid, rather than the first invalid line causing the whole dictionary not to load. I.e. a try except around the call to DictionaryEntry within SpeechDict.load. Ensure though that the 'comment' variable is cleared in a 'finally' block. This change would also allow you to log either the content or line number, for the offending line. |
When adding a dictionary entry with invalid regex, the error message now states that this is a regex error and qoutes the error. It is unfortunate, but the regex error is difficult to translate. If a user does manage to introduce an error into a dictionary file, then the nvda will import all valid lines in the file, reporting warnings to the log for lines in the dictionary that are invalid.
|
Incubated in 3a5c527 |
This change introduces a safety check when loading speech dictionaries, to ensure that nvda does not crash if the dictionaries contain invalid regex. This change also catches the same situation in the UI and informs the user that the regex is invalid.
Fixes #4834