New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credicle bug of this dictionary. #4834
Comments
Attachment default.dic added by vgjh2005 on 2015-01-20 08:15 |
Comment 1 by chrislm on 2015-01-20 09:34 |
Comment 2 by vgjh2005 on 2015-01-20 10:18 |
Comment 3 by jteh on 2015-01-20 10:40 |
The attachment referenced, just remove the .txt extension. |
Trace from log:
|
This can also be reproduced by adding a new entry through the GUI
|
From the brief testing I did earlier, doing it from the GUI doesn't seem to actually add the entry if you enter an invalid regexp. So, unless I'm missing something, while we should definitely handle this more gracefully, this can't create a startup failure because it never gets saved. That said, it may make some sense to protect against loading such an invalid entry at startup anyway just in case a file got corrupted or the like.
|
) Fixes #4834 PR: #6136 This change introduces a safety check when loading speech dictionaries, to ensure that nvda does not crash if the dictionaries contain invalid regex. This change also catches the same situation in the UI and informs the user that the regex is invalid. - When adding a dictionary entry with invalid regex, the error message now states that this is a regex error and qoutes the error. It is unfortunate, but the regex error is difficult to translate. - If a user does manage to introduce an error into a dictionary file, then the nvda will import all valid lines in the file, reporting warnings to the log for lines in the dictionary that are invalid.
When editing dictionary entries, feedback is now given for invalid regular expressions. NVDA no longer crashes if a dictionary file contains an invalid regular expression.
Reported by vgjh2005 on 2015-01-20 08:14
Hi:
This dic file include errors, and put it in speechdic folder, Press CTRL+ALT+N to restart NVDA, NVDA will not start again at all. There are also no error information. Thanks!
The text was updated successfully, but these errors were encountered: