Adjust the symbols list #6339
Closed
Adjust the symbols list #6339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…take up the full width of the dialog. Column items should have the same width, rather than specifying the widths by pixels.
This custom control extends a listCtrl with the help of a mixin so that a column can be specified to be resized to take up the remaining width available to a listCtrl.
|
@jcsteh Would you mind reviewing this? |
| # -*- coding: UTF-8 -*- | ||
| #settingsDialogs.py | ||
| #A part of NonVisual Desktop Access (NVDA) | ||
| #Copyright (C) 2006-2016 NV Access Limited |
There was a problem hiding this comment.
Please change file name above and copyright year to just 2016.
|
Accidentally referenced the wrong PR in the commit message. See: commit e533369 for incubating commit |
feerrenrut
added a commit
that referenced
this pull request
Sep 29, 2016
feerrenrut
added a commit
that referenced
this pull request
Oct 13, 2016
Merges in branches - 'i6101_SymbolsListCtrl' - 'i6348-documentFormattingDialog' - 'fixGuiAlignmentIssues' Adjust the symbols list. See PR #6339 Put the 'symbol' label above the list and have the list itself take up the full width of the dialog. Columns are spaced automatically, with one nominated to take up any extra available room. The first column was selected to expand more, as the information in the other columns can be viewed in the "change symbol" group. Fixes #6101 Restructure the document formatting dialog. See PR #6402 The document formatting settings dialog is restructured so that items can no longer "disappear" off the screen. The options are now in a scrolling section, grouped for clarity (paritcularly for new users / sighted users). A dialog description has been added, for further clarity. Fixes #6348 Fix Gui Alignment issues. See PR #6287 Fixes up various alignment and padding problems in the GUI. Introduces a new helper to abstract some of these details. Fixes #6317 (Gestures treeview does not look like a treeview) Fixes #5548 (Text control to specify the path when creating a portable copy is quite narrow) Fixes #6342 (Spacing between labels and combo boxes) Fixes #6343 (Inconsistency with vertical spacing between checkbox/label options) Fixes #6349 (input gestures dialog tree view too small)
|
This has been merged into master with commit: 87ed4d1 |
feerrenrut
added a commit
that referenced
this pull request
Oct 13, 2016
For PR #6287 - Various padding and alignment issues have been resolved. (#6317, #5548, #6342, #6343, #6349) For PR #6402 - The document formatting dialog has been adjusted so that the contents scrolls. (#6348) For PR #6339 - Adjusted the layout of the symbols pronunciation dialog so the full width of the dialog is used for the symbols list. (#6101)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6101
Extends PR #6178
Put the 'symbol' label above the list and have the list itself take up the full width of the dialog. Columns are spaced automatically, with one nominated to take up any extra available room.
The first column was selected to expand more, as the information in the other columns can be viewed in the "change symbol" group.