Indeterminate progress bar dialogs: only beep when progress bar output config includes beeps #6776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utput is configured to include beeps. Fixes nvaccess#6759.
|
Another use case is installing an addon. |
dkager
changed the title
feerrenrut
approved these changes
Jun 13, 2017
feerrenrut
added a commit
that referenced
this pull request
Jun 13, 2017
feerrenrut
added a commit
that referenced
this pull request
Jun 27, 2017
Beeps for indeterminate progress bar dialogs such as the update checker only when progress bar output is configured to include beeps. Issue #6759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6759
In indeterminate progress bar dialogs such as the update checker, only beep when done if progress bar output is configured to include beeps.