Live region change: handle a special case in Edge where live text is the child of the object that fires this event. re #7286 #7329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From translation svn revision: 33269 Authors: Jani Kinnunen <jani.kinnunen@wippies.fi> Isak Sand <isak.sand@gmail.com> Stats: 3 3 source/locale/fi/LC_MESSAGES/nvda.po 1 file changed, 3 insertions(+), 3 deletions(-)
From translation svn revision: 33269 Authors: Hrvoje Katic <hrvojekatic@gmail.com> Zvonimir Stanecic <zvonimirek222@yandex.com> Mario Percinic <mario.percinic@gmail.com> Stats: 3 0 user_docs/hr/userGuide.t2t 1 file changed, 3 insertions(+)
From translation svn revision: 33269 Authors: Takuya Nishimoto <nishimotz@gmail.com> Minako Nonogaki <minakonono3519@gmail.com> Stats: 1167 21 source/locale/ja/LC_MESSAGES/nvda.po 1 file changed, 1167 insertions(+), 21 deletions(-)
From translation svn revision: 33269 Authors: Joseph Lee <joseph.lee22590@gmail.com> Chang-Hwan Jang <462356@gmail.com> Dong Hee Park <hi@aheu.org> Stats: 1348 22 source/locale/ko/LC_MESSAGES/nvda.po 34 0 user_docs/ko/changes.t2t 8 4 user_docs/ko/userGuide.t2t 3 files changed, 1390 insertions(+), 26 deletions(-)
From translation svn revision: 33269 Authors: Cleverson Casarin Uliana <clever97@gmail.com> Marlin Rodrigues <marlincgrodrigues@yahoo.com.br> Stats: 1169 22 source/locale/pt_BR/LC_MESSAGES/nvda.po 1 file changed, 1169 insertions(+), 22 deletions(-)
From translation svn revision: 33269 Authors: Dan Pungă <dan.punga@gmail.com>, Florian Ionașcu <florianionascu@hotmail.com>, Alexandru Matei <alexandrumateistelian@gmail.com>, Nicuşor Untilă <nicusoruntila@yahoo.com> Stats: 42 41 source/locale/ro/LC_MESSAGES/nvda.po 3 2 user_docs/ro/changes.t2t 2 files changed, 45 insertions(+), 43 deletions(-)
From translation svn revision: 33269 Authors: Dinakar T.D. <td.dinkar@gmail.com> Stats: 6 2 user_docs/ta/userGuide.t2t 1 file changed, 6 insertions(+), 2 deletions(-)
From translation svn revision: 33269
…ss#6864) Fixes nvaccess#6812 Allow configuration to be stored in the local instead of the roaming appdata folder. For this, the `configInLocalAppData` parameter under `x86 HKEY_LOCAL_MACHINE\SOFTWARE\nvda` must be set to a value other than `0`
Fixes nvaccess#7004 Aria-placeholder now supported in Chrome, Firefox, Edge and IE. Placeholder is reported unless the field has some content.
For PRs: - nvaccess#6864 - NVDA user configuration files can now be stored in the user's local application data folder. This is enabled via a setting in the registry. See 'System wide parameters' in the user guide for more details. (Issue nvaccess#6812) - nvaccess#7055 - In web browsers, NVDA now reports placeholder values for fields (specifically, aria-placeholder is now supported). (Issue nvaccess#7004)
From translation svn revision: 33481 Authors: Bernd Dorer <bdorer@mailbox.org> David Parduhn <xkill85@gmx.net> Rene Linke <rene.linke@hamburg.de> Stats: 16 11 user_docs/de/changes.t2t 13 2 user_docs/de/userGuide.t2t 2 files changed, 29 insertions(+), 13 deletions(-)
From translation svn revision: 33481 Authors: Juan C. buno <oprisniki@gmail.com> Noelia Martinez <nrm1977@gmail.com> Stats: 6 2 source/locale/es/LC_MESSAGES/nvda.po 1 1 source/locale/es/symbols.dic 5 0 user_docs/es/changes.t2t 12 1 user_docs/es/userGuide.t2t 4 files changed, 24 insertions(+), 4 deletions(-)
From translation svn revision: 33481 Authors: Ali Aslani <aslani.ali@gmail.com> Mohammadreza Rashad <mohammadreza5712@gmail.com> Stats: 1182 33 source/locale/fa/LC_MESSAGES/nvda.po 17 11 user_docs/fa/changes.t2t 46 34 user_docs/fa/userGuide.t2t 3 files changed, 1245 insertions(+), 78 deletions(-)
From translation svn revision: 33481 Authors: Jani Kinnunen <jani.kinnunen@wippies.fi> Isak Sand <isak.sand@gmail.com> Stats: 6 2 source/locale/fi/LC_MESSAGES/nvda.po 5 0 user_docs/fi/changes.t2t 12 1 user_docs/fi/userGuide.t2t 3 files changed, 23 insertions(+), 3 deletions(-)
From translation svn revision: 33481 Authors: Michel such <michel.such@free.fr> Patrick ZAJDA <patrick@zajda.fr> Remy Ruiz <remyruiz@gmail.com> Bachir Benanou <ben_bach@yahoo.fr>, Abdelkrim Bensaid <abdelkrim.bensaid@free.fr> Stats: 6 2 source/locale/fr/LC_MESSAGES/nvda.po 7 2 user_docs/fr/changes.t2t 12 1 user_docs/fr/userGuide.t2t 3 files changed, 25 insertions(+), 5 deletions(-)
From translation svn revision: 33481 Authors: Juan C. buno <oprisniki@gmail.com> Stats: 6 2 source/locale/gl/LC_MESSAGES/nvda.po 1 1 source/locale/gl/symbols.dic 5 0 user_docs/gl/changes.t2t 12 1 user_docs/gl/userGuide.t2t 4 files changed, 24 insertions(+), 4 deletions(-)
From translation svn revision: 33481 Authors: Hrvoje Katic <hrvojekatic@gmail.com> Zvonimir Stanecic <zvonimirek222@yandex.com> Mario Percinic <mario.percinic@gmail.com> Stats: 1170 20 source/locale/hr/LC_MESSAGES/nvda.po 38 0 user_docs/hr/changes.t2t 29 5 user_docs/hr/userGuide.t2t 3 files changed, 1237 insertions(+), 25 deletions(-)
From translation svn revision: 33481 Authors: Simone Dal Maso <simone.dalmaso@gmail.com> Alberto Buffolino <a.buffolino@gmail.com> Stats: 1206 31 source/locale/it/LC_MESSAGES/nvda.po 1 file changed, 1206 insertions(+), 31 deletions(-)
From translation svn revision: 33481 Authors: Bram Duvigneau <bram@bramd.nl> Bart Simons <bart@bartsimons.be> A Campen <a.campen@wxs.nl> Leonard de Ruijter <leonard_dev@babbage.com> Stats: 1226 24 source/locale/nl/LC_MESSAGES/nvda.po 1 file changed, 1226 insertions(+), 24 deletions(-)
From translation svn revision: 33481 Authors: Dan Pungă <dan.punga@gmail.com> Florian Ionașcu <florianionascu@hotmail.com> Alexandru Matei <alexandrumateistelian@gmail.com> Nicuşor Untilă <nicusoruntila@yahoo.com> Stats: 78 71 source/locale/ro/LC_MESSAGES/nvda.po 5 1 user_docs/ro/changes.t2t 12 1 user_docs/ro/userGuide.t2t 3 files changed, 95 insertions(+), 73 deletions(-)
From translation svn revision: 33481 Authors: Ruslan Kolodyazhni <eye0@rambler.ru> Ruslan Shukhanov <ru2020slan@yandex.ru> Beqa Gozalishvili <beqaprogger@gmail.com> Aleksandr Lin'kov <kvark128@yandex.ru> alexander Yashin <a.jaszyn@ya.ru> Stats: 1178 22 source/locale/ru/LC_MESSAGES/nvda.po 41 0 user_docs/ru/changes.t2t 2 files changed, 1219 insertions(+), 22 deletions(-)
From translation svn revision: 33481 Authors: Nikola Jovic <wwenikola123@gmail.com> Janko Valencik <janko.valencik@alfanum.co.rs> Zvonimir <zvonimirek222@yandex.com> Danijela Popovic <vlajna95@gmail.com> Stats: 5 1 source/locale/sr/LC_MESSAGES/nvda.po 2 0 user_docs/sr/changes.t2t 12 1 user_docs/sr/userGuide.t2t 3 files changed, 19 insertions(+), 2 deletions(-)
From translation svn revision: 33481 Authors: Dinakar T.D. <td.dinkar@gmail.com> Stats: 1195 20 source/locale/ta/LC_MESSAGES/nvda.po 1 file changed, 1195 insertions(+), 20 deletions(-)
From translation svn revision: 33481 Authors: wangjanli@gmail.com maro.zhang@gmail.com Aaron Wu <waaron2000@gmail.com> Victor Cai <surfer0627@gmail.com> Stats: 25 25 source/locale/zh_TW/characterDescriptions.dic 1 file changed, 25 insertions(+), 25 deletions(-)
From translation svn revision: 33481
…ft+w (nvaccess#7258) * Added spelling errors to the list of quick navigation commands * Support for spelling error quick navigation in MS Word * Allow navigatingspelling/errors in the MS Word elements list * W is now used for for general errors/warnings in browse mode * Updated the user guide to include the errors quick navigation option * Include spelling in the labels for the Word elements list * Updated copyright headers * Changed WordDocumentSpellingErrorQuickNavItem.label to retrieve the text of the spelling error in a similar way to how this is done for comments and revisions Fixes nvaccess#6942
…that does expose value pattern yet does not raise the said event. re nvaccess#6337 (nvaccess#7132) Some combo boxes do expose value pattern but do not raise value change event. To get around this, selection on its children (items) will be tracked (same trick as combo boxes with no value pattern). * NVDAObjects/UIA: catch AttributeError seen in some lists. re nvaccess#6337. Caught by Jamie Teh (NV Access): when searching for items in store, the media type list is sometimes shown, and this may not have the required pattern at all. If this happens, Attribute Error is raised. When handling this, catch this error first, otherwise AttributeError will continue to be raised.
…alogs, and stop unuseful info from being announced as the dialog description. (nvaccess#7219)
…s 10. re nvaccess#6241 (nvaccess#6274) * UIA handler: add proper copyright header (based on Git log archive) * UIA objects: introduce a global suggestion list item class for Windows 10. re nvaccess#6241 Windows 10 uses suggestions list for vairious things, including Start menu suggestions, Store recommendations, Settings app and others. Thus introduce NVDAObjects.UIA.SuggestionListItem, which derives its power from searchui.py version (searchui.py version is gone). * SearchUI: remove unneeded imports * UIA: add support for Controller For property. re nvaccess#6241 Controller For property is used by an element to let another element depend on values given by the source element, useful if suggestions should be listed for a search field among other possibilities. For now, Controller For property has been added to property to event names map in UIA Handler. A UIA object that handles this event (a search box) is next. * Revert "UIA: add support for Controller For property. re nvaccess#6241" This reverts commit a3b1ce5. * UIA: add support for Controller For property. re nvaccess#6241 Controller For property is used by an element to let another element depend on values given by the source element, useful if suggestions should be listed for a search field among other possibilities. For now, Controller For property has been added to property to event names map in UIA Handler. A UIA object that handles this event (a search box) is next. * NVDAObjects.UIA: introduce Search Field that'll handle controller for and announce appearance of suggestions. re nvaccess#6241 Coming from Windows 10 App Essentials add-on: a Search Field is now available that'll detect controller for property event and announce either 'suggestions' or 'suggestions closed' if suggestions appear or disappear, respectively. This takes care of both Start Menu and other fields in Windows 10 (works best in Anniversary Update and later). * Search Field: check if search field is focused before asking for controller for object. re nvaccess#6241 Review from Mick Curran (NV Access): Do not waste a function call for fetching focused element. Besides, make sure to check if the focused control is the search field before proceeding to announce appearance of suggestions. * Update copyright years, add a docstring to UIA objects (__init__). * Suggestion: a new behavior to allow NVDA to detect and announce suggestions. re nvaccess#6241. Reviewed by Mick Curran (NV Access): announcement of search suggestion is something that NVDA should handle for other API's, such as suggestions in Firefox address bar, search suggestions in universal apps and so on. A new behavior named 'Suggestion' has been added that allows subclasses to provide custom routines when suggestions appear and disappear. This is handled by event_suggestionOpened and event_suggestionClosed, and by default NVDA will speak and braille this event. * UIA objects/Search field: use the new NVDAObjects.behaviors.Suggestion to announce suggestion appearance. re nvaccess#6241. Reviewed by Mick Curran (NV Access): Based on the new Suggestion behavior mix-in, it is now possible for various objects to provide custom routines to let users know the appearance of suggestions. Thus UIA/Search Field is the first object to use this routine. * UIA objects/suggestions list: use raw UIA base tree walker to obtain suggestion list (parent). re nvaccess#6241. Reviewed by Mick Curran (NV Access): it is better to use raw UIA for obtaining parent element. However, one must be careful to catch COM and value errors (COM because the element might not be there, and value because NULL pointer access is logged). The raw UIA method was also recommended by Derek Riemer. * UIA objects: updated comments, removed reference to Redstone. * UIA objects/Search field: don't allow suggestions detection be announced in Windows 10 Start menu for consistency with earlier versions of Windows. re nvaccess#6241. iN Windows 10 Start menu, suggestions are announced automaticlaly, so no need to provide suggestion announcements. * NVDAObjects/behaviors: rename 'Suggestion' to 'EditableTextWithSuggestions' so the behavior can be better described. re nvaccess#6241. If one inherits from 'Suggestion', the overall impression would be that the field is only going to display suggestions nad nothing else. Many suggestions are shown when text is entered, thus it is better to say 'EditableTextWithSuggestions' to better reflect what the behavior actually does. Also, a sound will be played to let users know the appearance of suggestions. (default vlaue). * Auto-suggestions: add a combo box in object presentation settings to configure how auto-suggestions should be announced. re nvaccess#6241 * User guide: document auto-suggestions notification setting. re nvaccess#6241. In the user guide, an explanatory text has been added to describe what auto-suggestions are. * Auto-suggestions: either play a sound or do nothing. re nvaccess#6241. Comments from Mick Curran and Jamie Teh (NV Access): no need for a separate message option when announcing appearance of auto-suggestions, as the sound cue will let the user of this fact. However, braille users should be notified of this regardless of this flag being turned on (deaf-blind users should be notified of this). User guide and settings dialog: changed the control type and label for auto-suggestions setting to reflect change in behavior. * Search suggestions: allow Windows 10 Start menu and Edge to provide search suggestions. re nvaccess#6241. Reviewed by Mick Curran (NV Access): allow Start menu search box and Edge's address omnibar to participate in providing auto-suggestions announcement. * Config: auto-suggestion setting is now part of configspec module. re nvaccess#6241 * Update to miscDeps containing auto suggestions sounds. * NVDAObjects.UIA: catch UnboundLocalError for parentElement if parentElement fetcher fails. re nvaccess#6241. In some cases, when Start menu opens, it isn't announced by NVDA. As a result, parent element fetcher fails when trying to instantiate suggestions list item, with a traceback that ends with UnboundLocalError. Catch this by moving the SuggestionsListItem selector to inside of the try block. * EditableTextWithSuggestions: remove braille message shown when suggestions close for consistency with other situations (such as browse mode toggle). re nvaccess#6241. * NVDAObjects.UIA.SuggestionListItem: braille suggestion results as flash messages. re nvaccess#6241. Suggestion from Davy Kager: provide a way to let braille users read search suggestion items. This is done by emulating some parts of speech.SpeakObjectProperties except the name and position info map will be fetched (position info map fetching is contingent on whether report position info setting is enabled from Object Presentation dialog). Ideally, NVDA objects should have a way to fetch braille flash messages for controls. Also reworded docstring for SuggestionListItem so it cna include other UIA-based suggestion list items such as Windows 8.x search results. * NVDAObjects.UIA.SuggestionsListItem: flash suggestion results in braille. re nvaccess#6241, nvaccess#6414. Instead of constructing the likely flash message, use a function used as part of Core issue 6414, which is much simpler than constructing the flash message from scratch. * UIA/SuggestionListItem/searchui: also classify Start search results context menu as a suggestions list item. re nvaccess#6241. Oddly, the same behavior that's applied to suggestion items must work in Start suggestion's context menu, otherwise menu items will not be announced.
…utput is configured to include beeps. (PR nvaccess#6776) Fixes nvaccess#6759
Beeps for indeterminate progress bar dialogs such as the update checker only when progress bar output is configured to include beeps. Issue nvaccess#6759
…ents message where the live text is its first child. In Edge (at least in Windows 10 Creators Update), there is a specific alert object used to announce alerts, with the automation ID of a11y-announcements-message. Unfortunately, the live text is not obj.name, but obj.firstChild.name, so catch this case for Edge.
|
… On Tue, Jun 27, 2017 at 7:02 PM, Joseph Lee ***@***.***> wrote:
Hi,
A PR for a PR ( secondary PR, in this case). Takes care of the following:
In Microsoft Edge, when live region change event is fired, the live text
turns out to be the child of the object that fires this event. Because the
current Core pR announces object name, this means in Edge, NVDA will say,
"alert". A special case is hereby provided in the Edge CP module to allow
NVDA to announce the actual live text (first child's name).
Thanks.
------------------------------
You can view, comment on, or merge this pull request online at:
#7329
Commit Summary
- L10n updates for: fi
- L10n updates for: hr
- L10n updates for: ja
- L10n updates for: ko
- L10n updates for: pt_BR
- L10n updates for: ro
- L10n updates for: ta
- Update translations.
- Allow configuration to be stored in local application data (PR #6864)
- Add support for aria placeholder (PR #7055)
- Update changes file
- L10n updates for: de
- L10n updates for: es
- L10n updates for: fa
- L10n updates for: fi
- L10n updates for: fr
- L10n updates for: gl
- L10n updates for: hr
- L10n updates for: it
- L10n updates for: nl
- L10n updates for: ro
- L10n updates for: ru
- L10n updates for: sr
- L10n updates for: ta
- L10n updates for: zh_TW
- Update translations.
- Allow quick navigation for spelling errors in MS Word using w and
shift+w (#7258)
- Update what's new
- NVDAObjects/UIA: forcefully raise value change event for combo boxes
that does expose value pattern yet does not raise the said event. re #6337
(#7132)
- Update what's new
- Support the date picker in Microsoft Outlook meeting / appointment
dialogs, and stop unuseful info from being announced as the dialog
description. (#7219)
- Update what's new
- UIA objects: introduce a global suggestion list item class for
Windows 10. re #6241 (#6274)
- Update what's new
- Indeterminate progress dialogs: only beep when done if progress bar
output is configured to include beeps. (PR #6776)
- Update changes file for PR #6776
- Merge branch 'master' into i7286edge
- Edge: announce alerts in case it was fired by accessibility
announcements message where the live text is its first child.
File Changes
- *M* miscDeps
<https://github.com/nvaccess/nvda/pull/7329/files#diff-0> (2)
- *M* nvdaHelper/vbufBackends/mshtml/mshtml.cpp
<https://github.com/nvaccess/nvda/pull/7329/files#diff-1> (1)
- *M* source/NVDAObjects/IAccessible/MSHTML.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-2> (3)
- *M* source/NVDAObjects/IAccessible/ia2Web.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-3> (4)
- *M* source/NVDAObjects/UIA/__init__.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-4> (60)
- *M* source/NVDAObjects/UIA/edge.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-5> (65)
- *M* source/NVDAObjects/__init__.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-6> (17)
- *M* source/NVDAObjects/behaviors.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-7> (29)
- *M* source/NVDAObjects/window/winword.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-8> (26)
- *M* source/UIAHandler.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-9> (6)
- *M* source/_UIAHandler.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-10> (7)
- *M* source/appModules/microsoftedgecp.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-11> (8)
- *M* source/appModules/outlook.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-12> (37)
- *M* source/appModules/searchui.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-13> (23)
- *M* source/braille.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-14> (15)
- *M* source/browseMode.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-15> (11)
- *M* source/config/__init__.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-16> (22)
- *M* source/config/configSpec.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-17> (1)
- *M* source/gui/__init__.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-18> (3)
- *M* source/gui/settingsDialogs.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-19> (7)
- *M* source/installer.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-20> (19)
- *M* source/locale/es/LC_MESSAGES/nvda.po
<https://github.com/nvaccess/nvda/pull/7329/files#diff-21> (8)
- *M* source/locale/es/symbols.dic
<https://github.com/nvaccess/nvda/pull/7329/files#diff-22> (2)
- *M* source/locale/fa/LC_MESSAGES/nvda.po
<https://github.com/nvaccess/nvda/pull/7329/files#diff-23> (1215)
- *M* source/locale/fi/LC_MESSAGES/nvda.po
<https://github.com/nvaccess/nvda/pull/7329/files#diff-24> (10)
- *M* source/locale/fr/LC_MESSAGES/nvda.po
<https://github.com/nvaccess/nvda/pull/7329/files#diff-25> (8)
- *M* source/locale/gl/LC_MESSAGES/nvda.po
<https://github.com/nvaccess/nvda/pull/7329/files#diff-26> (8)
- *M* source/locale/gl/symbols.dic
<https://github.com/nvaccess/nvda/pull/7329/files#diff-27> (2)
- *M* source/locale/hr/LC_MESSAGES/nvda.po
<https://github.com/nvaccess/nvda/pull/7329/files#diff-28> (1190)
- *M* source/locale/it/LC_MESSAGES/nvda.po
<https://github.com/nvaccess/nvda/pull/7329/files#diff-29> (1237)
- *M* source/locale/ja/LC_MESSAGES/nvda.po
<https://github.com/nvaccess/nvda/pull/7329/files#diff-30> (1188)
- *M* source/locale/ko/LC_MESSAGES/nvda.po
<https://github.com/nvaccess/nvda/pull/7329/files#diff-31> (1370)
- *M* source/locale/nl/LC_MESSAGES/nvda.po
<https://github.com/nvaccess/nvda/pull/7329/files#diff-32> (1250)
- *M* source/locale/pt_BR/LC_MESSAGES/nvda.po
<https://github.com/nvaccess/nvda/pull/7329/files#diff-33> (1191)
- *M* source/locale/ro/LC_MESSAGES/nvda.po
<https://github.com/nvaccess/nvda/pull/7329/files#diff-34> (156)
- *M* source/locale/ru/LC_MESSAGES/nvda.po
<https://github.com/nvaccess/nvda/pull/7329/files#diff-35> (1200)
- *M* source/locale/sr/LC_MESSAGES/nvda.po
<https://github.com/nvaccess/nvda/pull/7329/files#diff-36> (6)
- *M* source/locale/ta/LC_MESSAGES/nvda.po
<https://github.com/nvaccess/nvda/pull/7329/files#diff-37> (1215)
- *M* source/locale/zh_TW/characterDescriptions.dic
<https://github.com/nvaccess/nvda/pull/7329/files#diff-38> (50)
- *M* source/shlobj.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-39> (20)
- *M* source/speech.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-40> (27)
- *M* source/virtualBuffers/MSHTML.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-41> (3)
- *M* source/virtualBuffers/__init__.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-42> (32)
- *M* source/virtualBuffers/gecko_ia2.py
<https://github.com/nvaccess/nvda/pull/7329/files#diff-43> (9)
- *M* user_docs/de/changes.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-44> (27)
- *M* user_docs/de/userGuide.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-45> (15)
- *M* user_docs/en/changes.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-46> (9)
- *M* user_docs/en/userGuide.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-47> (28)
- *M* user_docs/es/changes.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-48> (5)
- *M* user_docs/es/userGuide.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-49> (13)
- *M* user_docs/fa/changes.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-50> (28)
- *M* user_docs/fa/userGuide.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-51> (80)
- *M* user_docs/fi/changes.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-52> (5)
- *M* user_docs/fi/userGuide.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-53> (13)
- *M* user_docs/fr/changes.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-54> (9)
- *M* user_docs/fr/userGuide.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-55> (13)
- *M* user_docs/gl/changes.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-56> (5)
- *M* user_docs/gl/userGuide.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-57> (13)
- *M* user_docs/hr/changes.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-58> (38)
- *M* user_docs/hr/userGuide.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-59> (37)
- *M* user_docs/ko/changes.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-60> (34)
- *M* user_docs/ko/userGuide.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-61> (12)
- *M* user_docs/ro/changes.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-62> (11)
- *M* user_docs/ro/userGuide.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-63> (13)
- *M* user_docs/ru/changes.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-64> (41)
- *M* user_docs/sr/changes.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-65> (2)
- *M* user_docs/sr/userGuide.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-66> (13)
- *M* user_docs/ta/userGuide.t2t
<https://github.com/nvaccess/nvda/pull/7329/files#diff-67> (8)
Patch Links:
- https://github.com/nvaccess/nvda/pull/7329.patch
- https://github.com/nvaccess/nvda/pull/7329.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#7329>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFGivU0jPS0aeHuoBHeI2nZPDTeOuFElks5sIaY9gaJpZM4OHXls>
.
--
Derek Riemer: Improving the world one byte at a time!
- University of Colorado Boulder Department of computer science, 4th
year undergraduate student.
- Accessibility enthusiast.
- Proud user of the NVDA screen reader.
- Open source enthusiast.
- Skier.
Personal website <http://derekriemer.com>
|
|
Adding proper live region support to Edge will require major changes to UI Automation core itself. For instance, if a list (say chat log) is marked up as a live region and a new list item is appended, the live region is fired on the list, not the list item. But in this case the correct child to speak would be the lastChild, not firstChild. In deed, if a child was inserted in the middle this would be impossible to find with out caching and comparing the tree. And even if we did do that, the first live region change would still be wrong, unless we cached the tree before the first ever live region. In short, conversation between ATs and Microsoft is needed, which is slowly happening. |
|
Hi, in this case, I’m happy for it to be held up until it is truly fixed from Microsoft. Thanks.
|
|
Hi, If #8466 turns out to be a corner case of this, then I say this PR should be closed in favor of that one, as it also addresses alert text spread over multiple children (via tree interceptor). For now, I'm taking this offline until someone says otherwise. Thanks. |
|
@feerrenrut this one as well worthy to label as edge spartan for future reference. |
feerrenrut
added
the
z app/edge/spartan (archived)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
A PR for a PR ( secondary PR, in this case). Takes care of the following:
In Microsoft Edge, when live region change event is fired, the live text turns out to be the child of the object that fires this event. Because the current Core pR announces object name, this means in Edge, NVDA will say, "alert". A special case is hereby provided in the Edge CP module to allow NVDA to announce the actual live text (first child's name).
Thanks.