New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIA: Handle combo boxes with value pattern #6337

Closed
josephsl opened this Issue Sep 6, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@josephsl
Collaborator

josephsl commented Sep 6, 2016

Hi,

May apply to Windows 8 and later: there are combo boxes that does expose value pattern (for example, Settings/Devices/Auto play). As of now, NVDA handles ones without value pattern, but it might be helpful to work with ones that does expose this pattern.

Thanks.

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Sep 6, 2016

Contributor
Contributor

jcsteh commented Sep 6, 2016

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Sep 6, 2016

Collaborator

Hi, In that case, it might be best to follow conventions unless MS does something interesting in Redstone 2. Thanks for letting us know about this.

From: James Teh [mailto:notifications@github.com]
Sent: Monday, September 5, 2016 6:00 PM
To: nvaccess/nvda
Cc: Joseph Lee; Author
Subject: Re: [nvaccess/nvda] UIA: Handle combo boxes with value pattern (#6337)

We already use the value pattern where it's available. In fact, that's
the way we already get the value from this particular combo box.

We don't report changes here because even though it supports the value
pattern, it does not fire value property change events. Narrator gets
around this by reporting the selection change event on child items. We
can probably do the same in this specific case.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #6337 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkDG6u2qPBtdPH7F0mhAf6A5VBx7bks5qnLsTgaJpZM4J1YAm .Image removed by sender.

Collaborator

josephsl commented Sep 6, 2016

Hi, In that case, it might be best to follow conventions unless MS does something interesting in Redstone 2. Thanks for letting us know about this.

From: James Teh [mailto:notifications@github.com]
Sent: Monday, September 5, 2016 6:00 PM
To: nvaccess/nvda
Cc: Joseph Lee; Author
Subject: Re: [nvaccess/nvda] UIA: Handle combo boxes with value pattern (#6337)

We already use the value pattern where it's available. In fact, that's
the way we already get the value from this particular combo box.

We don't report changes here because even though it supports the value
pattern, it does not fire value property change events. Narrator gets
around this by reporting the selection change event on child items. We
can probably do the same in this specific case.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #6337 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AHgLkDG6u2qPBtdPH7F0mhAf6A5VBx7bks5qnLsTgaJpZM4J1YAm .Image removed by sender.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl May 3, 2017

Collaborator

Hi,
Returning to this issue...

Redstone 2 did not change this, so I guess a PR might be in order. Thanks.

Collaborator

josephsl commented May 3, 2017

Hi,
Returning to this issue...

Redstone 2 did not change this, so I guess a PR might be in order. Thanks.

josephsl added a commit to josephsl/nvda that referenced this issue May 3, 2017

NVDAObjects/UIA: forcefully raise value change event for combo boxes …
…that does expose value pattern yet does not raise the said event. re #6337.

Some combo boxes does expose value pattern but does not raise value change event. To get around this, selection on its children (items) will be tracked (same trick as combo boxes with no value pattern).

josephsl added a commit to josephsl/nvda that referenced this issue May 30, 2017

NVDAObjects/UIA: catch AttributeError seen in some lists. re #6337.
Caught by Jamie Teh (NV Access): when searching for items in store, the media type list is sometimes shown, and this may not have the required pattern at all. If this happens, Attribute Error is raised. When handling this, catch this error first, otherwise AttributeError will continue to be raised.

michaelDCurran added a commit that referenced this issue Jun 23, 2017

NVDAObjects/UIA: forcefully raise value change event for combo boxes …
…that does expose value pattern yet does not raise the said event. re #6337 (#7132)

Some combo boxes do expose value pattern but do not raise value change event. To get around this, selection on its children (items) will be tracked (same trick as combo boxes with no value pattern).

* NVDAObjects/UIA: catch AttributeError seen in some lists. re #6337.

Caught by Jamie Teh (NV Access): when searching for items in store, the media type list is sometimes shown, and this may not have the required pattern at all. If this happens, Attribute Error is raised. When handling this, catch this error first, otherwise AttributeError will continue to be raised.
@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Jun 23, 2017

Contributor

Fixed by pr #7132

Contributor

michaelDCurran commented Jun 23, 2017

Fixed by pr #7132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment