Sconscript: use WIN32_WINNT_WIN7 in architecture sconscript #7560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to make NVDA more compatible with Windows 7 and later. re nvaccess#6718.
|
sorry,
See the win10sdk branch In the git repository:
https://github.com/nvaccess/nvda/tree/win10sdk
It already does this, plus switches to the windows 10 sdk, removes the
hardcoded /subsystem of windows,5.0, and fixes up some deprecated
GetVersion checks.
|
|
Hi, I see, didn’t see this due to vagueness of some commit messages. Thanks.
From: Michael Curran [mailto:notifications@github.com]
Sent: Sunday, September 3, 2017 6:41 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Author <author@noreply.github.com>
Subject: Re: [nvaccess/nvda] Sconscript: use WIN32_WINNT_WIN7 in architecture sconscript (#7560)
sorry,
See the win10sdk branch In the git repository:
https://github.com/nvaccess/nvda/tree/win10sdk
It already does this, plus switches to the windows 10 sdk, removes the
hardcoded /subsystem of windows,5.0, and fixes up some deprecated
GetVersion checks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#7560 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkCHhNwgLa2p3JZOJPkl12Rh5pTfGks5se1UvgaJpZM4PLXf1> .
|
|
No matter. I have not yet got around to actually submitting the pr, but
just thought I'd point out the branch in case you went and spent time
doing other stuff.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#6718 (based on work done via #7546)
Summary of the issue:
None
Description of how this pull request fixes the issue:
Currently architecture sconscript assumes use of WIN32_WINNT_WS03 to make NVDA compatible with Windows XP SP2 and later. Now that XP support is gone, it would be better to target Windows 7 by using WIN32_WINNT_Win7.
Testing performed:
NVDA compiled successfully with the changes made.
Known issues with pull request:
None.
Change log entry:
None (can be part of 7546).