memoize parseMarkdown #702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs to be revisited after #843 |
|
mhhh… this might still be useful for #695 |
|
I’m guessing we don’t need this anymore after recent optimizations? |
|
yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make operations such as (re)indexation (#543) and lazy config (#695) much more usable in preview, and might save a few seconds during build (instead of parsing each file 2 or 3 times, we'd do it only once), for example to assist with last-modified (#699) and hashing (#758).
To make sure that we don't inflate the memory requirements I'm capping this arbitrarily to a store that has a maximum of 16^4 shortCode keys — as long as the percentage of conflicts is small the impact on speed is not going to be a problem. (Note: we take care of checking the full hash before deciding to use the cache, so as not to mix two files which would happen to share the same shortCode slot.)