Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support GUI test #964

Draft
wants to merge 45 commits into
base: master
Choose a base branch
from
Draft

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Feb 18, 2024

Pull request type

  • Build and release changes -> [build/release]

Which ticket is resolved?

dev-ML
https://sourceforge.net/p/omegat/mailman/omegat-development/thread/47347769-ccd4-4272-9155-9eaf96c0296c%40northside.tokyo/#msg58743384

What does this PR change?

  • refacotr main gui classes to allow GUI test - MainWindowMenuHandler class inherited from BaseMenuHanlder abstract class - Tester should implement MenuHandler class for test inherited from BaseMenuHandler class

  • Add testGui configuration on gradle

  • Set gui test source under test/gui

  • Introduce TestCoreGUI class

  • Add BasicMenuItemTest

Other information

@miurahr miurahr changed the title feat: support GUI unit test feat: support GUI test Feb 18, 2024
@miurahr miurahr force-pushed the topic/miurahr/test/gui/acceptance-test branch from bd6b5d1 to 6fafc3b Compare February 19, 2024 23:03
Copy link

❌ Run Gradle test failed:

1 similar comment
Copy link

❌ Run Gradle test failed:

- refacotr main gui classes to allow GUI test
    - MainWindowMenuHandler class inherited from BaseMenuHanlder
      abstract class
    - Tester should implement MenuHandler class for test inherited
      from BaseMenuHandler class
- Add testGui configuration on gradle
- Set gui test source under test/gui
- Introduce TestCoreGUI class
- Add BasicMenuItemTest

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
- Split looong-method into smaller one
- Give component name

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
@miurahr miurahr force-pushed the topic/miurahr/test/gui/acceptance-test branch from cf758b8 to 2213112 Compare February 26, 2024 01:31
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
…ain package

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
…ainWindow#getApplicationFrame

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Copy link

❌ Run Gradle test failed: https://gradle.com/s/zxd4xuucwyflw

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Copy link

github-actions bot commented Mar 4, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/xvvpar3xfdzg4

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Copy link

github-actions bot commented Mar 5, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/u4eiqhop6qm2k

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Copy link

github-actions bot commented Mar 6, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/crjbb4kmmzfhu

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Copy link

github-actions bot commented Mar 6, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/n5geytulsqtlc

Copy link

github-actions bot commented Mar 6, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/d3cx6rqlub63i

- Add more actions
- Extend IMainWindow#addSearchWindow and IMainWindow#getSearchWindows
- Move internal TestMainWindow class as regular class
- refactor ProjectUICommands.doRecycleTrans and ProjectUICommands.doInsertTrans

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
@miurahr miurahr force-pushed the topic/miurahr/test/gui/acceptance-test branch from 45496b4 to cc164e1 Compare March 6, 2024 23:57
Copy link

github-actions bot commented Mar 7, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/but4hqd54whwi

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Copy link

github-actions bot commented Mar 7, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/iawvfz3bwxntu

Copy link

github-actions bot commented Mar 7, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/73dbfbutd7mz4

Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Copy link

github-actions bot commented Mar 9, 2024

❌ Unit Tests, Quality checks, and Acceptance Tests failed.

Please look a Gradle Scan page for details:
https://gradle.com/s/enck273o6ptfs

@miurahr
Copy link
Member Author

miurahr commented Mar 9, 2024

  • It seems better to add definitions of UI names at end of class definition because of test purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant