Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332080: Update troff man page for javadoc #19181

Closed
wants to merge 1 commit into from
Closed

Conversation

hns
Copy link
Member

@hns hns commented May 10, 2024

Please review a patch to update to the javadoc man page to add the --no-fonts option and fix a typo.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332080: Update troff man page for javadoc (Task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19181/head:pull/19181
$ git checkout pull/19181

Update a local copy of the PR:
$ git checkout pull/19181
$ git pull https://git.openjdk.org/jdk.git pull/19181/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19181

View PR using the GUI difftool:
$ git pr show -t 19181

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19181.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 10, 2024

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 10, 2024

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332080: Update troff man page for javadoc

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

  • 1b476f5: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic
  • 1c5f150: 8331734: Atomic MemorySegment VarHandle operations fails for element layouts
  • 65abf24: 8331866: Add warnings for locale data dependence
  • d215bc4: 8332066: AArch64: Math test failures since JDK-8331558
  • d11e70a: 8331646: Add specific regression leap year tests
  • f95c937: 8331577: RISC-V: C2 CountLeadingZerosV
  • 675fbe6: 8331993: Add counting leading/trailing zero tests for Integer
  • 242446b: 8331931: JFR: Avoid loading regex classes during startup
  • 45792c5: 8331352: error: template-id not allowed for constructor/destructor in C++20
  • 1547a69: 8327696: [TESTBUG] "javax/swing/JTable/KeyBoardNavigation/KeyBoardNavigation.java" test instruction needs to be corrected
  • ... and 28 more: https://git.openjdk.org/jdk/compare/ad78b7fa67ba30cab2e8f496e4c765be15deeca6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8332080: Update troff man page for javadoc 8332080: Update troff man page for javadoc May 10, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label May 10, 2024
@openjdk
Copy link

openjdk bot commented May 10, 2024

@hns The following label will be automatically applied to this pull request:

  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the javadoc javadoc-dev@openjdk.org label May 10, 2024
@mlbridge
Copy link

mlbridge bot commented May 10, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 10, 2024
@hns
Copy link
Member Author

hns commented May 13, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 13, 2024

Going to push as commit 1484153.
Since your change was applied there have been 49 commits pushed to the master branch:

  • 391bbbc: 8330584: IGV: XML does not save all node properties
  • adaa509: 8327499: MethodHandleStatics.traceLambdaForm includes methods that cannot be generated
  • 5a8df41: 8331535: Incorrect prompt for Console.readLine
  • 3e3f7cf: 8330387: Crash with a different types patterns (primitive vs generic) in instanceof
  • d517d2d: 8331764: C2 SuperWord: refactor _align_to_ref/_mem_ref_for_main_loop_alignment
  • 5053b70: 8278255: Add more warning text in ReentrantLock and ReentrantReadWriteLock
  • 32c7681: 8332029: Provide access to initial value of stderr via JavaLangAccess
  • f9a1d33: 8332020: jwebserver tool prints invalid URL in case of IPv6 address binding
  • b87a7e9: 8144100: Incorrect case-sensitive equality in com.sun.net.httpserver.BasicAuthenticator
  • 1dac34f: 8331098: [Aarch64] Fix crash in Arrays.equals() intrinsic with -CCP
  • ... and 39 more: https://git.openjdk.org/jdk/compare/ad78b7fa67ba30cab2e8f496e4c765be15deeca6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 13, 2024
@openjdk openjdk bot closed this May 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@hns Pushed as commit 1484153.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org
2 participants