Skip to content

WRKLDS-1449: disable DynamicResourceAllocation in order to upgrade to resource.k8s.io/v1alpha3 #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

WRKLDS-1449: disable DynamicResourceAllocation in order to upgrade to resource.k8s.io/v1alpha3 #2016

wants to merge 2 commits into from

Conversation

atiratree
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 29, 2024 •
edited by openshift-ci bot
Loading

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

Hello @atiratree! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 29, 2024
@openshift-ci openshift-ci bot requested review from JoelSpeed and soltysh August 29, 2024 19:26
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atiratree
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atiratree
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

@atiratree: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ce99f850-663d-11ef-80ec-3e328423e950-0

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2024
@atiratree atiratree mentioned this pull request Aug 30, 2024
Closed
@atiratree
disable DynamicResourceAllocation in order to upgrade to resource.k8s…
4ae0667 
….io/v1alpha3

introduce DynamicResourceAllocationSchedulersConfigOnly to keep the
ProfileCustomizations in the schedulers.config.openshift.io
@atiratree
make update
3bded71
@atiratree
Copy link
Member Author

verify-crd-schema error was already present before

error in config/v1/zz_generated.featuregated-crd-manifests/schedulers.config.openshift.io/DynamicResourceAllocationSchedulersConfigOnly.yaml: NoBools: crd/schedulers.config.openshift.io version/v1 field/^.spec.mastersSchedulable may not be a boolean

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

@atiratree: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-crd-schema 3bded71 link true /test verify-crd-schema

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Aug 30, 2024

/hold

Instead of this please update the kube-apiserver operator to check the version it is installing and enable the correct APIs for the level it is installing.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2024
@atiratree
Copy link
Member Author

closing in favor of openshift/cluster-kube-apiserver-operator#1731 and openshift/installer#8973

@atiratree atiratree closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@soltysh soltysh Awaiting requested review from soltysh

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atiratree @openshift-ci-robot @deads2k