Skip to content

Conversation

rh-roman
Copy link

@rh-roman rh-roman commented Oct 2, 2025

No description provided.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2025
@openshift-ci openshift-ci bot requested review from deads2k and everettraven October 2, 2025 18:09
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 2, 2025
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

Hello @rh-roman! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

Hi @rh-roman. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rh-roman rh-roman force-pushed the test-streaming-collection-encoding branch from 162227a to 0affae9 Compare October 2, 2025 19:28
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2025
@rh-roman rh-roman changed the title Enable StreamingCollectionEncoding for tech preview OCPSTRAT-2467: Add feature gate for StreamingCollectionEncoding Oct 2, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2025

@rh-roman: This pull request references OCPSTRAT-2467 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.21" instead.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@benluddy
Copy link
Contributor

benluddy commented Oct 2, 2025

/retitle [release-4.19] OCPSTRAT-2467: Add feature gate for StreamingCollectionEncoding

@openshift-ci openshift-ci bot changed the title OCPSTRAT-2467: Add feature gate for StreamingCollectionEncoding [release-4.19] OCPSTRAT-2467: Add feature gate for StreamingCollectionEncoding Oct 2, 2025
@benluddy
Copy link
Contributor

benluddy commented Oct 2, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 2, 2025
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 2, 2025
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

@benluddy: This PR was included in a payload test run from openshift/kubernetes#2478
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/28fb66a0-9fca-11f0-9331-8f7b43dad041-0

@JoelSpeed
Copy link
Contributor

@rh-roman What's the motivation behind this PR? There's no description nor link to an appropriate jira card?

@kevinrizza
Copy link
Member

@JoelSpeed We have been having a discussion about https://issues.redhat.com/browse/OCPSTRAT-2467, where the relevant reasoning is written in the description. We are starting by pulling all of these changes behind tech preview, which is what this PR is for. If it helps, we can discuss offline in more detail, but there's some significant asks from the business especially from HCM to pick this feature back to help with performance related to large LIST requests in managed clusters

@JoelSpeed
Copy link
Contributor

@kevinrizza I've already been filled on on the strat, didn't make the connection that this PR was relevant/related to it.

Are we likely to be creating appropriate bugs to link to PRs for each of the required backports? This change looks fine, but there's admin to do

From a hygiene and future archeology perspective, I would expect the PR description to be included with appropriate detail please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants