-
Notifications
You must be signed in to change notification settings - Fork 572
[release-4.19] OCPSTRAT-2467: Add feature gate for StreamingCollectionEncoding #2517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.19
Are you sure you want to change the base?
[release-4.19] OCPSTRAT-2467: Add feature gate for StreamingCollectionEncoding #2517
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hello @rh-roman! Some important instructions when contributing to openshift/api: |
Hi @rh-roman. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
162227a
to
0affae9
Compare
@rh-roman: This pull request references OCPSTRAT-2467 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.21" instead. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retitle [release-4.19] OCPSTRAT-2467: Add feature gate for StreamingCollectionEncoding |
/ok-to-test |
@benluddy: This PR was included in a payload test run from openshift/kubernetes#2478
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/28fb66a0-9fca-11f0-9331-8f7b43dad041-0 |
@rh-roman What's the motivation behind this PR? There's no description nor link to an appropriate jira card? |
@JoelSpeed We have been having a discussion about https://issues.redhat.com/browse/OCPSTRAT-2467, where the relevant reasoning is written in the description. We are starting by pulling all of these changes behind tech preview, which is what this PR is for. If it helps, we can discuss offline in more detail, but there's some significant asks from the business especially from HCM to pick this feature back to help with performance related to large LIST requests in managed clusters |
@kevinrizza I've already been filled on on the strat, didn't make the connection that this PR was relevant/related to it. Are we likely to be creating appropriate bugs to link to PRs for each of the required backports? This change looks fine, but there's admin to do From a hygiene and future archeology perspective, I would expect the PR description to be included with appropriate detail please |
No description provided.