Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "TRT-1587: Revert #4275 "MCO-1092: Adapt the MCO's featuregate usage to new API"" #4306

Closed
wants to merge 2 commits into from
Closed

Revert "TRT-1587: Revert #4275 "MCO-1092: Adapt the MCO's featuregate usage to new API"" #4306

wants to merge 2 commits into from

Conversation

dkhater-redhat
Copy link
Contributor

Reverts the revert of #4295

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 3, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 3, 2024 •
edited by openshift-ci bot

@dkhater-redhat: This pull request references TRT-1587 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Reverts the revert of #4295

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@dkhater-redhat
Copy link
Contributor Author

/retest-required

@dkhater-redhat
Copy link
Contributor Author

/payload 4.16 ci blocking

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 3, 2024

@dkhater-redhat: trigger 5 job(s) of type blocking for the ci release of OCP 4.16

  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.16-upgrade-from-stable-4.15-e2e-azure-sdn-upgrade
  • periodic-ci-openshift-release-master-ci-4.16-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.16-e2e-aws-sdn-serial
  • periodic-ci-openshift-hypershift-release-4.16-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b0634950-f201-11ee-9cad-da785e489f45-0

This was referenced Apr 10, 2024
Merged
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2024
@dkhater-redhat dkhater-redhat force-pushed the revert-4295-revert-4275-1711718271986 branch from b5f224c to a07cfa0 Compare April 11, 2024 15:28
@dkhater-redhat dkhater-redhat force-pushed the revert-4295-revert-4275-1711718271986 branch from a07cfa0 to 595cbe7 Compare April 11, 2024 16:17
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2024
@dkhater-redhat dkhater-redhat force-pushed the revert-4295-revert-4275-1711718271986 branch from 595cbe7 to 10eb9b7 Compare April 11, 2024 16:19
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

@dkhater-redhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 10eb9b7 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-hypershift 10eb9b7 link true /test e2e-hypershift
ci/prow/okd-scos-e2e-aws-ovn 10eb9b7 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn 10eb9b7 link true /test e2e-aws-ovn
ci/prow/e2e-gcp-op-techpreview 10eb9b7 link false /test e2e-gcp-op-techpreview
ci/prow/e2e-gcp-op 10eb9b7 link true /test e2e-gcp-op

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dkhater-redhat
Copy link
Contributor Author

#4315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dkhater-redhat @openshift-ci-robot @openshift-merge-robot