Replace DB Netz AG and DB Station&Service AG by DB InfraGo AG #9016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two subsidiaries are merged as of 1 January 2024. Press release: https://www.deutschebahn.com/de/presse/pressestart_zentrales_uebersicht/DB-Aufsichtsrat-bringt-gemeinwohlorientierte-Infrastrukturgesellschaft-DB-InfraGO-AG-auf-den-Weg-11872708#
LaoshuBaby
reviewed
Dec 7, 2023
| "displayName": "DB Netz AG", | ||
| "id": "dbnetzag-9c1a6c", | ||
| "displayName": "DB InfraGO AG", | ||
| "id": "dbinfrago-9c1a6c", |
There was a problem hiding this comment.
If it is a rebrand, acquisition, merger, etc., our recommended approach is to use the old name as matchNames, e.g.:
Suggested change
| "id": "dbinfrago-9c1a6c", | |
| "id": "dbinfrago-9c1a6c", | |
| "matchNames": ["DB Netz AG", "DB Station&Service AG"], |
Of course, this also depends on the specific brand changes, so it is not mandatory
There was a problem hiding this comment.
There will be a mechanical edit in the next weeks. The old values will disappear. Therefore, I do not see any need in keeping old names.
|
Please consider also removing the legal form from the |
|
Any news on this @Nakaner ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two subsidiaries are merged as of 1 January 2024.
Press release: https://www.deutschebahn.com/de/presse/pressestart_zentrales_uebersicht/DB-Aufsichtsrat-bringt-gemeinwohlorientierte-Infrastrukturgesellschaft-DB-InfraGO-AG-auf-den-Weg-11872708#