Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DB Netz AG and DB Station&Service AG by DB InfraGo AG #9016

Merged
merged 1 commit into from
May 25, 2024
+10 −19
Merged

Replace DB Netz AG and DB Station&Service AG by DB InfraGo AG #9016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 3 additions & 12 deletions data/operators/man_made/surveillance.json
View file
Open in desktop
Expand Up @@ -896,21 +896,12 @@
}
},
{
"displayName": "DB Netz AG",
"id": "dbnetzag-9c1a6c",
"displayName": "DB InfraGO AG",
"id": "dbinfrago-9c1a6c",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is a rebrand, acquisition, merger, etc., our recommended approach is to use the old name as matchNames, e.g.:

Suggested change
"id": "dbinfrago-9c1a6c",
"id": "dbinfrago-9c1a6c",
"matchNames": ["DB Netz AG", "DB Station&Service AG"],

Of course, this also depends on the specific brand changes, so it is not mandatory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be a mechanical edit in the next weeks. The old values will disappear. Therefore, I do not see any need in keeping old names.

"locationSet": {"include": ["001"]},
"tags": {
"man_made": "surveillance",
"operator": "DB Netz AG"
}
},
{
"displayName": "DB Station&Service AG",
"id": "dbstationandserviceag-9c1a6c",
"locationSet": {"include": ["001"]},
"tags": {
"man_made": "surveillance",
"operator": "DB Station&Service AG"
"operator": "DB InfraGO AG"
}
},
{
Expand Down
6 changes: 3 additions & 3 deletions data/operators/power/substation.json
View file
Open in desktop
Expand Up @@ -1588,12 +1588,12 @@
}
},
{
"displayName": "DB Netz AG",
"displayName": "DB InfraGO AG",
"id": "dbnetzag-7ff171",
"locationSet": {"include": ["de"]},
"tags": {
"operator": "DB Netz AG",
"operator:wikidata": "Q896765",
"operator": "DB InfraGO AG",
"operator:wikidata": "Q122870674",
"power": "substation"
}
},
Expand Down
8 changes: 4 additions & 4 deletions data/operators/route/tracks.json
View file
Open in desktop
Expand Up @@ -25,12 +25,12 @@
}
},
{
"displayName": "DB Netz AG",
"id": "dbnetzag-7a762a",
"displayName": "DB InfraGO AG",
"id": "dbinfrago-7a762a",
"locationSet": {"include": ["de"]},
"tags": {
"operator": "DB Netz AG",
"operator:wikidata": "Q896765",
"operator": "DB InfraGO AG",
"operator:wikidata": "Q122870674",
"route": "tracks"
}
},
Expand Down