New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop ruby 18mode, liberate ActiveSupport #1414
Conversation
@padrino/core-members could someone remind me, why Travis separately tests against AS 3.1? Should we drop these tests? |
I think good timing. |
This probably has to be done in conjunction with bumping to 0.12.0 for the next release right? Is there anything we should wait on before pushing this into master (and doing a 0.12.0) release? |
It's difficult for us to drop http_router at next release. |
I think we can surely release 0.11.4 before that. |
Yeah if you guys think it's wise, I will start preparing a 0.11.4 (for before we merge in this request) for release this week. @padrino/core-members ? |
👍 |
I think it's good. 👍 |
This branch will be rebased a lot before 0.12 merge. Do not lean 😳 |
drop ruby 18mode, liberate ActiveSupport
Is it not possible to accept both ActiveSupport 3 and 4? AFAIK, Mongoid 3 will not work alongside AR4, only Mongoid 4, which has not been officially released. |
AFAIK, padrino does not rely on AS4 features, so that should be considered. |
ref #1323
Are we there yet?