Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop ruby 18mode, liberate ActiveSupport #1414

Merged
merged 3 commits into from Nov 15, 2013
Merged

drop ruby 18mode, liberate ActiveSupport #1414

merged 3 commits into from Nov 15, 2013

Conversation

ujifgc
Copy link
Member

@ujifgc ujifgc commented Sep 15, 2013

ref #1323

Are we there yet?

@ujifgc
Copy link
Member Author

ujifgc commented Sep 15, 2013

@padrino/core-members could someone remind me, why Travis separately tests against AS 3.1? Should we drop these tests?

@ghost ghost assigned ujifgc Sep 15, 2013
@namusyaka
Copy link
Contributor

I think good timing.

@nesquena
Copy link
Member

This probably has to be done in conjunction with bumping to 0.12.0 for the next release right? Is there anything we should wait on before pushing this into master (and doing a 0.12.0) release?

@ujifgc
Copy link
Member Author

ujifgc commented Sep 16, 2013

Well, we have 2 blockers:
#1256 is virtually unfixable within current Tilt API and template naming
#863 should disappear with retiring http_router

@namusyaka
Copy link
Contributor

It's difficult for us to drop http_router at next release.
My router works only 2.0.0 at present.

@ujifgc
Copy link
Member Author

ujifgc commented Sep 18, 2013

I think we can surely release 0.11.4 before that.

@nesquena
Copy link
Member

Yeah if you guys think it's wise, I will start preparing a 0.11.4 (for before we merge in this request) for release this week. @padrino/core-members ?

@Ortuna
Copy link
Member

Ortuna commented Sep 22, 2013

👍

@namusyaka
Copy link
Contributor

I think it's good. 👍

@ujifgc
Copy link
Member Author

ujifgc commented Sep 30, 2013

This branch will be rebased a lot before 0.12 merge. Do not lean 😳

ujifgc added a commit that referenced this pull request Nov 15, 2013
drop ruby 18mode, liberate ActiveSupport
@ujifgc ujifgc merged commit 6a1acc6 into master Nov 15, 2013
@ujifgc ujifgc deleted the 19mode branch November 15, 2013 12:13
@dphase
Copy link

dphase commented Nov 15, 2013

Is it not possible to accept both ActiveSupport 3 and 4? AFAIK, Mongoid 3 will not work alongside AR4, only Mongoid 4, which has not been officially released.

@skade
Copy link
Contributor

skade commented Nov 16, 2013

AFAIK, padrino does not rely on AS4 features, so that should be considered.

ujifgc added a commit that referenced this pull request Nov 18, 2013
Ortuna pushed a commit to Ortuna/padrino-framework that referenced this pull request Jan 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants