Revert "fix bundle for ruby 1.8.7. Before allowing AS 4, we MUST branch ... #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch away with statement about dropping 1.8.7" This reverts commit d805891.
|
@romansergey The router update/upgrade is the main blocker here 😦. Until we get that integrated we're going to leave 1.8.x support. Thanks! |
|
got it. thanks! |
|
@Ortuna I don't think these issues are related. We have a plan to release 0.12 without ruby 18mode, and we have a plan on upgrading router. We could actually release 0.12 without new router for 19mode. |
|
Whoops, didn't see that #1414 was a PR. @romansergey to amend my previous comment: "#1414 will do the revert" 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's time