-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOBP-637,IOBP-440] New transactions list and details with biz events integration #5768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected stories |
…-transaction-list
….com/pagopa/io-app into IOBP-637-biz-events-transaction-list
mastro993
requested changes
Jun 10, 2024
...eatures/payments/bizEventsTransaction/components/PaymentsBizEventsTransactionTotalAmount.tsx
Outdated
Show resolved
Hide resolved
.../payments/bizEventsTransaction/screens/PaymentsTransactionBizEventsCartItemDetailsScreen.tsx
Outdated
Show resolved
Hide resolved
ts/features/payments/bizEventsTransaction/screens/PaymentsTransactionBizEventsListScreen.tsx
Outdated
Show resolved
Hide resolved
mastro993
requested changes
Jun 10, 2024
.../payments/bizEventsTransaction/screens/PaymentsTransactionBizEventsCartItemDetailsScreen.tsx
Outdated
Show resolved
Hide resolved
….com/pagopa/io-app into IOBP-637-biz-events-transaction-list
mastro993
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hantex9
added a commit
that referenced
this pull request
Jun 12, 2024
##⚠️ This PR depends on #5768⚠️ ## Short description This PR implements the ability to view “legacy” transactions that are not available through biz-events at the moment. ## List of changes proposed in this pull request - Added a legacy list screen that retrieves the old transactions not available with biz-events; - Connected the legacy list screen with the previous transaction details that shows transaction info with a reduced amount of data; - Added a CTA to access to this new page from: - `PaymentsHomeEmptyScreenContent` - Into the biz-events transaction list when the user reaches the end of the list. ## How to test - Checkout the dev-server with the following PR: pagopa/io-dev-api-server#369 - Open the new payment landing page and try to reach the CTA from the entry point listed above, you should be able to see the previous transactions with less data shown. ## Preview https://github.com/pagopa/io-app/assets/34343582/7e759311-d0f6-48af-962e-edb28c0bb682 --------- Co-authored-by: Federico Mastrini <federicomastrini93@gmail.com> Co-authored-by: Jacopo Pompilii <Jacopo.pompilii@pagopa.it>
Hantex9
added a commit
that referenced
this pull request
Jun 13, 2024
##⚠️ This PR depends on #5768⚠️ ## Short description This PR adds the ability to be able to download the transaction pdf receipt, save it or share it ## List of changes proposed in this pull request - Added a button into the transaction details screen that starts the receipt pdf download; - Created a PDF preview screen that renders the PDF content and has a CTA to save or share the file. - Applied a patch to the react-native library that implements the `readAsArrayBuffer` function used by the code-gen to manage a blob response automatically. ## How to test - Generate the open API definitions on the dev-server and on the app - Run `npm install` to apply the patch to the `react-native` readAsArrayBuffer function ## Preview https://github.com/pagopa/io-app/assets/34343582/f1b5700a-7cfd-4000-b76c-7a46aa63549e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR implements the new transaction list and transaction details powered by biz-events by managing more information such as logo, payment method used, cart type transactions and so on.
List of changes proposed in this pull request
io-app-design-system
library to the latest version in order to support theListItemInfo
with a payment method logo.Why is a new feature-folder being created?
Because the old transactions feature will still have to be available since in addition to biz-events in an early transition there will also be dated transactions
How to test
If you tap on a transaction, you can access its detail
Preview
preview.mov