Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equalto test as value-level analogue of reference-level sameas test. #283

Merged
merged 2 commits into from Dec 12, 2013

Conversation

thomasvnoort
Copy link

I was missing a test for value-level equality, analogue to the sameas test that compares pointers. For instance, to filter a hash like {{ users|selectattr("email", "equalto", "jinja@pocoo.org") }}.

@berkerpeksag
Copy link
Contributor

It would be good to add a test to jinja2/testsuite/tests.py.

@thomasvnoort
Copy link
Author

I don't mean to be impatient, but is somebody looking into merging this pull request? To me it seems like a simple yet powerful addition.

@mitsuhiko
Copy link
Contributor

That sounds like a good idea for the new filter support.

@mitsuhiko mitsuhiko merged commit 40367c4 into pallets:master Dec 12, 2013
@mitsuhiko
Copy link
Contributor

Sorry for not handling this for so long. I'm trying to fix this. For the time being, send me an email if you have any more requests that need proper review to jump ahead of the github notification list.

@thomasvnoort
Copy link
Author

Wonderful, thanks for your quick reply!

@thomasvnoort thomasvnoort deleted the equalto-test branch December 13, 2013 08:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants