Change HTML output according to HTML -- Living Standard spec

[Kubo2]

Supersedes #963.

Any thoughts what else could be included?

[xPaw]

You didn't change border to a style property here.

[Kubo2]

Thanks for noticing, my mistake. I think I will better rewrite phpinfo()'s output more heavily, to use more stylesheets instead of obsolete attrs etc. and target this to 7.1.

[quantumpacket]

Speaking of using stylesheets. highlight_*() from what I can see in the commit it is now using the style attr. If you are targetting 7.1 then you could use classes instead and use http://caniuse.com/#feat=style-scoped (provided there is enough browser support by then).

[Kubo2]

(provided there is enough browser support by then).

Sadly there isn't and seems there won't be support for that in the near
future (additionaly, Chrome already removed it). But it doesn't matter at
all, there's no problem for stylesheets to have scoped attr with (possible)
forward compatibility and additionaly all classNames prefixed e.g. with php-
.

What's your opinion on this?

Thanks,
Kubo2

2015-05-27 0:06 GMT+02:00 Orion notifications@github.com:

In ext/standard/info.c
#1301 (comment):

@@ -637,12 +640,14 @@ PHPAPI void php_print_info(int flag)
the_time = time(NULL);
ta = php_localtime_r(&the_time, &tmbuf);

•        php_info_print("<a href=\"http://www.php.net/\"><img border=\"0\" src=\"");
  

•       if (ta && (ta->tm_mon==3) && (ta->tm_mday==1)) {
  

•           php_info_print(PHP_EGG_LOGO_DATA_URI "\" alt=\"PHP logo\" /></a>");
  

•       } else {
  

•           php_info_print(PHP_LOGO_DATA_URI "\" alt=\"PHP logo\" /></a>");
  

•       }
  

•       php_info_print("<a href=\"http://www.php.net/\"><img border=\"0\" src=\"");
  

Speaking of using stylesheets. highlight__() from what I can see in the
commit it is now using the style attr. If you are targetting 7.1 then you
could use classes instead and use http://caniuse.com/#feat=style-scoped *(provided
there is enough browser support by then)_.

—
Reply to this email directly or view it on GitHub
https://github.com/php/php-src/pull/1301/files#r31084860.

[krakjoe]

@Kubo2 I think this needs splitting: I don't like tests changing so that lengths of strings that are known, can now be any length, and this PR is doing that too much, I don't see a good reason for that. The length of the strings are still known, because you are matching against them.

While I think it is unlikely that anyone is relying on the form of markup, it is possible, and so I can't see a reasonable way to merge this into 7 branches, since it touches so much markup.

I'm going to close this PR, and suggest that you push forward for this at a later time, at the boundary of a major version. I'm aware you done this in time for 7.0, but there is nothing I can do to rewrite the history of what has already happened, unfortunately.