Optimize saving relational fields

[BlackbitDevs]

Changes in this pull request

Every time when relational field is changed Pimcore always delete all relations related to the field

pimcore/models/DataObject/Concrete/Dao.php

Lines 235 to 239 in dd81ef4

	$dataExists = $this->db->fetchOne('SELECT `src_id` FROM `object_relations_'. $this->model->getClassId().'`
	WHERE '.$condition .' LIMIT 1');
	if ($dataExists) {
	$this->db->executeStatement('DELETE FROM object_relations_' . $this->model->getClassId() . ' WHERE ' . $condition);
	}

If relational field have a lot of relations this behavior may take time to firstly delete all relations and then insert it again.

This PR changed standard behavior and relations will be deleted only if it's really been deleted but not all relations. And only new relations will be inserted.

Additional info

WHAT

🤖 Generated by Copilot at 76a0928

This pull request makes several formatting, readability, and performance changes to various PHP files in the pimcore/pimcore repository. It adds empty lines to the end of some files and removes redundant comment lines from others to comply with the PSR-12 coding standard and improve code quality. It also improves the logic for deleting relational objects from the database when updating a data object to avoid unnecessary queries and errors.

🤖 Generated by Copilot at 76a0928

Sing, O Muse, of the code review that brought many changes
To the files of Pimcore, the framework of web development
How the diligent coder, following the PSR-12 standard
Added empty lines to the end of each PHP file

HOW

🤖 Generated by Copilot at 76a0928

• Add empty lines to the end of several PHP files to follow the PSR-12 coding standard (link, link, link, link, link, link, link, link, link, link, link, link)
• Remove unnecessary comment lines from generateCodes in Pattern and writeSaveQueue in CoreCacheHandler to improve code readability and quality (link, link)
• Remove misplaced comment line from Service to avoid confusion (link)
• Add condition to save in AbstractRelations to avoid unnecessary database queries and errors when saving empty relations (link)
• Add logic to update in Dao to detect and delete relational objects that are no longer associated with the object (link, link, link)

[github-actions]

Review Checklist

• Target branch (11.0 for bug fixes, others 11.x)
• Tests (if it's testable code, there should be a test for it - get help)
• Docs (every functionality needs to be documented, see here)
• Migration incl. install.sql (e.g. if the database schema changes, ...)
• Upgrade notes (deprecations, important information, migration hints, ...)
• Label
• Milestone

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[jdreesen]

Why fetch the data before the condition if it's only used inside it?