Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/admin: support admin check table on partition table (#12796) #13140

Merged
merged 3 commits into from Nov 7, 2019
Merged

util/admin: support admin check table on partition table (#12796) #13140

merged 3 commits into from Nov 7, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Nov 5, 2019 •
edited

What problem does this PR solve?

cherry-pick https://github.com/pingcap/tidb/pull/12796/files

conflict file:

        both modified:   executor/admin_test.go
        both modified:   planner/core/exhaust_physical_plans.go
        both modified:   planner/core/find_best_task.go
        both modified:   planner/core/planbuilder.go

@crazycs520
Copy link
Contributor Author

/run-all-tests

bb7133
bb7133 reviewed Nov 5, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor Author

/run-all-tests

zimulala
zimulala approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 7, 2019

/run-all-tests

@zimulala zimulala merged commit 536e259 into pingcap:release-3.0 Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crazycs520 @sre-bot @bb7133 @zimulala