Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/admin: support admin check table on partition table #12796

Merged
merged 9 commits into from Oct 29, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Oct 17, 2019

What problem does this PR solve?

  • Support admin check table on the partition table. The admin check table doesn't take effect on the partition table before.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Support admin check table on the partition table

@crazycs520
Copy link
Contributor Author

/run-all-tests

@djshow832
Copy link
Contributor

LGTM

@djshow832 djshow832 added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 25, 2019
@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #12796 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #12796   +/-   ##
=======================================
  Coverage   80.28%   80.28%           
=======================================
  Files         466      466           
  Lines      110000   110000           
=======================================
  Hits        88308    88308           
  Misses      14964    14964           
  Partials     6728     6728

zimulala
zimulala previously approved these changes Oct 29, 2019
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. sig/execution SIG execution and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 29, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants