Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: check table name length when rename table (#13339) #13346

Merged
merged 4 commits into from Nov 13, 2019
Merged

ddl: check table name length when rename table (#13339) #13346

merged 4 commits into from Nov 13, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Nov 11, 2019

cherry-pick #13339 to release-3.0

What problem does this PR solve? 

create table t (a int,b int);
-- below sql should be error, but will execute successful before.
rename table t to txxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx;
(1059, u"Identifier name 'txxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx' is too long")

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the issue that the rename table ddl should check the new table name length.

@sre-bot
Copy link
Contributor Author

sre-bot commented Nov 11, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Nov 11, 2019
Merged
@sre-bot sre-bot added status/DNM type/bug-fix This PR fixes a bug. labels Nov 11, 2019
tangenta
tangenta reviewed Nov 11, 2019
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bb7133
bb7133 reviewed Nov 11, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2019
@crazycs520
Copy link
Contributor

/run-all-tests

@crazycs520 crazycs520 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 13, 2019
zimulala
zimulala approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala merged commit 733824f into pingcap:release-3.0 Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@tangenta tangenta tangenta left review comments

@zimulala zimulala zimulala approved these changes

@djshow832 djshow832 Awaiting requested review from djshow832

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bug-fix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sre-bot @crazycs520 @bb7133 @zimulala @tangenta