Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: check table name length when rename table (#13339) #13346

Merged
merged 4 commits into from Nov 13, 2019
Merged

ddl: check table name length when rename table (#13339) #13346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11b52d1
ddl: check table name length when rename table
crazycs520 Nov 11, 2019
80e6306
Merge branch 'release-3.0' into release-3.0-bcad46400999
crazycs520 Nov 12, 2019
30aa30d
fix test
crazycs520 Nov 12, 2019
c3f4981
Merge branch 'release-3.0' into release-3.0-bcad46400999
crazycs520 Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions ddl/db_test.go
View file
Open in desktop
Expand Up @@ -2056,6 +2056,10 @@ func (s *testDBSuite) testRenameTable(c *C, sql string, isAlterTable bool) {
assertErrorCode(c, s.tk, fmt.Sprintf(sql, "test1.t1", "test1.T1"), tmysql.ErrTableExists)
}

// Test rename table name too long.
assertErrorCode(c, s.tk, "rename table test1.t1 to test1.txxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx", tmysql.ErrTooLongIdent)
assertErrorCode(c, s.tk, "alter table test1.t1 rename to test1.txxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx", tmysql.ErrTooLongIdent)

s.tk.MustExec("drop database test1")
}

Expand Down
3 changes: 3 additions & 0 deletions ddl/ddl_api.go
View file
Open in desktop
Expand Up @@ -3112,6 +3112,9 @@ func (d *ddl) RenameTable(ctx sessionctx.Context, oldIdent, newIdent ast.Ident,
if is.TableExists(newIdent.Schema, newIdent.Name) {
return infoschema.ErrTableExists.GenWithStackByArgs(newIdent)
}
if err := checkTooLongTable(newIdent.Name); err != nil {
return errors.Trace(err)
}

job := &model.Job{
SchemaID: newSchema.ID,
Expand Down