Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip destroy monitor when ignore_exporter is true #2197

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Smityz
Copy link
Contributor

@Smityz Smityz commented May 6, 2023

when ignore_exporter: true is setting, tiup should skip destroying node exporter

Signed-off-by: Smityz <smityz@qq.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 6, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from lucklove and srstack May 6, 2023 11:10
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (600390f) 56.14% compared to head (7b297a0) 55.97%.
Report is 70 commits behind head on master.

❗ Current head 7b297a0 differs from pull request most recent head e73a281. Consider uploading reports for the commit e73a281 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2197      +/-   ##
==========================================
- Coverage   56.14%   55.97%   -0.17%     
==========================================
  Files         320      320              
  Lines       33866    33866              
==========================================
- Hits        19014    18956      -58     
- Misses      12583    12641      +58     
  Partials     2269     2269              
Flag Coverage Δ
cluster 44.83% <100.00%> (-0.18%) ⬇️
dm 25.69% <100.00%> (-0.05%) ⬇️
playground 15.73% <ø> (-0.02%) ⬇️
tiup 15.88% <ø> (-0.02%) ⬇️
unittest 22.66% <ø> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nexustar
Copy link
Collaborator

I suggest to move this if to "instCount[inst.GetManageHost()]--".So it will have the same behave like deploy.(If there are two instant on one machine, only one has "nomonitor" config, tiup cluster will deyloy and destroy monitor on this machine)

@Smityz
Copy link
Contributor Author

Smityz commented May 17, 2023

I suggest to move this if to "instCount[inst.GetManageHost()]--".So it will have the same behave like deploy.(If there are two instant on one machine, only one has "nomonitor" config, tiup cluster will deyloy and destroy monitor on this machine)

updated

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: srstack
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 13, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Aug 13, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-13 13:26:53.89523038 +0000 UTC m=+464778.444246366: ☑️ agreed by srstack.
  • 2023-08-13 13:27:13.742076099 +0000 UTC m=+464798.291092085: ✖️🔁 reset by srstack.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 13, 2023

New changes are detected. LGTM label has been removed.

Copy link
Contributor

ti-chi-bot bot commented Feb 3, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants